Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(415)

Issue 319363002: DevTools: CPUFlameChart: stick function entry color to the function name and url. (Closed)

Created:
6 years, 6 months ago by loislo
Modified:
6 years, 6 months ago
Reviewers:
alph, pfeldman, yurys
CC:
aandrey+blink_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, devtools-reviews_chromium.org, eustas+blink_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, malch+blink_chromium.org, paulirish+reviews_chromium.org, pfeldman+blink_chromium.org, sergeyv+blink_chromium.org, vsevik+blink_chromium.org, yurys+blink_chromium.org
Visibility:
Public.

Description

DevTools: CPUFlameChart: stick function entry color to the function name and url. The old color generator had the dependency from line number too and it was a bad idea because after a change in the source file the entry would change the color. Also the entry colors had implicit dependency from the order of processing. BUG=382116 R=alph@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175787

Patch Set 1 #

Total comments: 1

Patch Set 2 : comments addressed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -13 lines) Patch
M Source/devtools/front_end/components/FlameChart.js View 1 3 chunks +8 lines, -8 lines 0 comments Download
M Source/devtools/front_end/profiler/CPUProfileFlameChart.js View 2 chunks +8 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
loislo
6 years, 6 months ago (2014-06-07 13:02:00 UTC) #1
alph
lgtm https://codereview.chromium.org/319363002/diff/1/Source/devtools/front_end/components/FlameChart.js File Source/devtools/front_end/components/FlameChart.js (right): https://codereview.chromium.org/319363002/diff/1/Source/devtools/front_end/components/FlameChart.js#newcode269 Source/devtools/front_end/components/FlameChart.js:269: for (var i = 0; i < id.length; ...
6 years, 6 months ago (2014-06-07 13:28:22 UTC) #2
loislo
The CQ bit was checked by loislo@chromium.org
6 years, 6 months ago (2014-06-09 07:32:22 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/loislo@chromium.org/319363002/20001
6 years, 6 months ago (2014-06-09 07:33:11 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 6 months ago (2014-06-09 08:36:47 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-09 08:37:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/15258)
6 years, 6 months ago (2014-06-09 08:37:01 UTC) #7
loislo
6 years, 6 months ago (2014-06-09 11:16:52 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r175787 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698