Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 319343002: Bugfix in inlined versions of Array.indexOf() and Array.lastIndexOf() with a regression test. (Closed)

Created:
6 years, 6 months ago by Igor Sheludko
Modified:
6 years, 6 months ago
Reviewers:
Benedikt Meurer
CC:
v8-dev
Visibility:
Public.

Description

Bugfix in inlined versions of Array.indexOf() and Array.lastIndexOf() with a regression test. BUG=chromium:381534 LOG=N R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21733

Patch Set 1 #

Patch Set 2 : Rebasing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -23 lines) Patch
M src/hydrogen.cc View 1 2 chunks +28 lines, -22 lines 0 comments Download
M src/hydrogen-instructions.cc View 1 chunk +4 lines, -1 line 0 comments Download
A test/mjsunit/regress/regress-crbug-381534.js View 1 chunk +40 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Igor Sheludko
PTAL
6 years, 6 months ago (2014-06-07 10:14:47 UTC) #1
Benedikt Meurer
LGTM, thanks
6 years, 6 months ago (2014-06-10 08:36:16 UTC) #2
Igor Sheludko
6 years, 6 months ago (2014-06-10 09:01:55 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r21733 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698