Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Side by Side Diff: src/objects.h

Issue 31933003: Make PropertyCell::UpdatedType return a handle. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 9179 matching lines...) Expand 10 before | Expand all | Expand 10 after
9190 9190
9191 // Sets the value of the cell and updates the type field to be the union 9191 // Sets the value of the cell and updates the type field to be the union
9192 // of the cell's current type and the value's type. If the change causes 9192 // of the cell's current type and the value's type. If the change causes
9193 // a change of the type of the cell's contents, code dependent on the cell 9193 // a change of the type of the cell's contents, code dependent on the cell
9194 // will be deoptimized. 9194 // will be deoptimized.
9195 static void SetValueInferType(Handle<PropertyCell> cell, 9195 static void SetValueInferType(Handle<PropertyCell> cell,
9196 Handle<Object> value); 9196 Handle<Object> value);
9197 9197
9198 // Computes the new type of the cell's contents for the given value, but 9198 // Computes the new type of the cell's contents for the given value, but
9199 // without actually modifying the 'type' field. 9199 // without actually modifying the 'type' field.
9200 // TODO(mstarzinger): Return value should be handlified. 9200 static Handle<Type> UpdatedType(Handle<PropertyCell> cell,
9201 static Type* UpdatedType(Handle<PropertyCell> cell, 9201 Handle<Object> value);
9202 Handle<Object> value);
9203 9202
9204 void AddDependentCompilationInfo(CompilationInfo* info); 9203 void AddDependentCompilationInfo(CompilationInfo* info);
9205 9204
9206 void AddDependentCode(Handle<Code> code); 9205 void AddDependentCode(Handle<Code> code);
9207 9206
9208 // Casting. 9207 // Casting.
9209 static inline PropertyCell* cast(Object* obj); 9208 static inline PropertyCell* cast(Object* obj);
9210 9209
9211 inline Address TypeAddress() { 9210 inline Address TypeAddress() {
9212 return address() + kTypeOffset; 9211 return address() + kTypeOffset;
(...skipping 1206 matching lines...) Expand 10 before | Expand all | Expand 10 after
10419 } else { 10418 } else {
10420 value &= ~(1 << bit_position); 10419 value &= ~(1 << bit_position);
10421 } 10420 }
10422 return value; 10421 return value;
10423 } 10422 }
10424 }; 10423 };
10425 10424
10426 } } // namespace v8::internal 10425 } } // namespace v8::internal
10427 10426
10428 #endif // V8_OBJECTS_H_ 10427 #endif // V8_OBJECTS_H_
OLDNEW
« no previous file with comments | « no previous file | src/objects.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698