Issue 319283002: [FastTextAutosizer] Inherit the text autosizing multiplier

Issue 319283002: [FastTextAutosizer] Inherit the text autosizing multiplier (Closed)

Created:
6 years, 6 months ago by pdr.

Modified:
6 years, 6 months ago

Reviewers:
skobes

CC:
blink-reviews, blink-reviews-rendering, zoltan1, blink-reviews-css, eae+blinkwatch, ed+blinkwatch_opera.com, leviw+renderwatch, dglazkov+blink, apavlov+blink_chromium.org, jchaffraix+rendering, darktears, pdr., rune+blink, rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

[FastTextAutosizer] Inherit the text autosizing multiplier Because font is inherited we had bugs due to the text autosizing multiplier and the font getting out of sync. This patch changes the text autosizing multiplier to inherit like the font properties. TEST=display-type-change.html which failed before this patch. BUG=378959 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175820

Patch Set 1 #

Patch Set 2 : Cleanup #

Patch Set 3 : Rietveld bugs.. #

Total comments: 2

Patch Set 4 : Remove non-critical changes #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+78 lines, -7 lines)			Patch
M	LayoutTests/TestExpectations	View	1	1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/text-autosizing/display-type-change.html	View	1	1 chunk	+33 lines, -0 lines	0 comments	Download
A	LayoutTests/platform/mac/fast/text-autosizing/display-type-change-expected.png	View	1	Binary file		0 comments	Download
A	LayoutTests/platform/mac/fast/text-autosizing/display-type-change-expected.txt	View	1	1 chunk	+35 lines, -0 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.h	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/rendering/style/RenderStyle.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	Source/core/rendering/style/StyleInheritedData.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/rendering/style/StyleInheritedData.cpp	View		3 chunks	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/style/StyleVisualData.h	View		2 chunks	+0 lines, -2 lines	0 comments	Download
M	Source/core/rendering/style/StyleVisualData.cpp	View		2 chunks	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

skobes

lgtm! https://chromiumcodereview.appspot.com/319283002/diff/40001/Source/core/css/resolver/StyleAdjuster.cpp File Source/core/css/resolver/StyleAdjuster.cpp (right): https://chromiumcodereview.appspot.com/319283002/diff/40001/Source/core/css/resolver/StyleAdjuster.cpp#newcode1 Source/core/css/resolver/StyleAdjuster.cpp:1: /* revert this file (no significant change) https://chromiumcodereview.appspot.com/319283002/diff/40001/Source/core/rendering/FastTextAutosizer.cpp ...

6 years, 6 months ago (2014-06-09 17:53:54 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/319283002/60001

6 years, 6 months ago (2014-06-09 18:31:30 UTC) #4

Message was sent while issue was closed.

Change committed as 175820

Expand Messages | Collapse Messages