Third Party Authentication for Android Part II - Java Native Interface plumbing

remoting/client/jni/chromoting_jni_runtime.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_CLIENT_JNI_CHROMOTING_JNI_RUNTIME_H_
 #define REMOTING_CLIENT_JNI_CHROMOTING_JNI_RUNTIME_H_
 
 #include <jni.h>
 #include <string>
 
@@ skipping 78 matching lines @@
   // Updates video frame bitmap. |bitmap| must be an instance of
   // android.graphics.Bitmap. Call on the display thread.
   void UpdateFrameBitmap(jobject bitmap);
 
   // Updates cursor shape. Call on display thread.
   void UpdateCursorShape(const protocol::CursorShapeInfo& cursor_shape);
 
   // Draws the latest image buffer onto the canvas. Call on the display thread.
   void RedrawCanvas();
 
+  // Pops up a third party login page to fetch token required for
+  // authentication.

[Lambros, 2014/06/07 01:38:12]

Add "Call on UI thread."
I think these methods are grouped together by which thread they are called on,
so perhaps move this just below CommitPairingCredentials()?

[kelvinp, 2014/06/09 18:42:32]

Done.

+  void FetchThirdPartyToken(const GURL& token_url,
+                            const std::string& client_id,
+                            const std::string& scope);

[Lambros, 2014/06/07 01:38:12]

Same here. Make sure the ordering of methods in .cc file follows the header file
(assuming it does so already).

[kelvinp, 2014/06/09 18:42:32]

Done.

+
  private:
   ChromotingJniRuntime();
 
   // Forces a DisconnectFromHost() in case there is any active or failed
   // connection, then proceeds to tear down the Chromium dependencies on which
   // all sessions depended. Because destruction only occurs at application exit
   // after all connections have terminated, it is safe to make unretained
   // cross-thread calls on the class.
   virtual ~ChromotingJniRuntime();
 
@@ skipping 18 matching lines @@
   scoped_refptr<ChromotingJniInstance> session_;
 
   friend struct DefaultSingletonTraits<ChromotingJniRuntime>;
 
   DISALLOW_COPY_AND_ASSIGN(ChromotingJniRuntime);
 };
 
 }  // namespace remoting
 
 #endif