Componentize TiclInvalidationService

Componentize TiclInvalidationService

Moves gcm_invalidation_bridge and ticl_invalidation_service files from
chrome/browser/sync to components/invalidation.

Refactors TiclInvalidationService so it no longer depends on
chrome/common/chrome_content_client.h.  Its only dependency on this file
was a call to GetUserAgent().  It was removed by changing the class so
that the user agent is specified at construction time.

Moves some related tests and test framework classes into
components/invalidation.

Updates the gyp files to prevent much of the TICL invalidation service
code from being built on Android.  This is the same setup as before the
move, though it does fix a bug where one of the previously componentized
files was accidentally enabled for building on Android.

BUG=336571
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276838

[rlarocque, 2014-06-06 21:57:56]

This includes the long-awaited componentization of TiclInvalidationService.

+pavely for review.
+bartfab for comment on removing the TestBrowserThreadBundle.  I think I may be
doing something wrong there, but I haven't been able to run the tests in such a
way that they catch it.
+blundell as FYI.

Please review.

https://codereview.chromium.org/319223002/diff/20001/components/invalidation/...
File components/invalidation/invalidation_service_test_template.h (left):

https://codereview.chromium.org/319223002/diff/20001/components/invalidation/...
components/invalidation/invalidation_service_test_template.h:104:
content::TestBrowserThreadBundle thread_bundle_;
I removed this line because I wanted to break the dependency on content/ and I
was curious to see which tests actually needed it.  Much to my surprise,
everything passed.

I guess this wasn't really needed?  See discussions in

https://codereview.chromium.org/221963003/diff/20001/chrome/browser/invalidat...

and 

https://codereview.chromium.org/221963003/diff/20001/chrome/browser/invalidat...

[pavely, 2014-06-09 16:52:18]

lgtm

[bartfab (slow), 2014-06-10 11:45:13]

TestBrowserThreadBundle removal lgtm. If the tests all pass, it was obviously no
longer needed after all the refactoring that went into this code over the past
weeks.

https://codereview.chromium.org/319223002/diff/20001/components/invalidation/...
File components/invalidation/invalidation_service_test_template.h (left):

https://codereview.chromium.org/319223002/diff/20001/components/invalidation/...
components/invalidation/invalidation_service_test_template.h:104:
content::TestBrowserThreadBundle thread_bundle_;
On 2014/06/06 21:57:56, rlarocque wrote:
> I removed this line because I wanted to break the dependency on content/ and I
> was curious to see which tests actually needed it.  Much to my surprise,
> everything passed.
> 
> I guess this wasn't really needed?  See discussions in
> 
>
https://codereview.chromium.org/221963003/diff/20001/chrome/browser/invalidat...
> 
> and 
> 
>
https://codereview.chromium.org/221963003/diff/20001/chrome/browser/invalidat...

As you can see in the comment, the TestBrowserThreadBundle was needed because to
correctly dispose of an object owned by a TestingProfile. This test appears to
no longer be using TestingProfile. Thus, it should work without a 
TestBrowserThreadBundle.

[rlarocque, 2014-06-10 17:18:24]

On 2014/06/10 11:45:13, bartfab wrote:
> TestBrowserThreadBundle removal lgtm. If the tests all pass, it was obviously
no
> longer needed after all the refactoring that went into this code over the past
> weeks.
> 
>
https://codereview.chromium.org/319223002/diff/20001/components/invalidation/...
> File components/invalidation/invalidation_service_test_template.h (left):
> 
>
https://codereview.chromium.org/319223002/diff/20001/components/invalidation/...
> components/invalidation/invalidation_service_test_template.h:104:
> content::TestBrowserThreadBundle thread_bundle_;
> On 2014/06/06 21:57:56, rlarocque wrote:
> > I removed this line because I wanted to break the dependency on content/ and
I
> > was curious to see which tests actually needed it.  Much to my surprise,
> > everything passed.
> > 
> > I guess this wasn't really needed?  See discussions in
> > 
> >
>
https://codereview.chromium.org/221963003/diff/20001/chrome/browser/invalidat...
> > 
> > and 
> > 
> >
>
https://codereview.chromium.org/221963003/diff/20001/chrome/browser/invalidat...
> 
> As you can see in the comment, the TestBrowserThreadBundle was needed because
to
> correctly dispose of an object owned by a TestingProfile. This test appears to
> no longer be using TestingProfile. Thus, it should work without a 
> TestBrowserThreadBundle.

Thanks for the confirmation.  I wasn't sure if it had been refactored out of
existence, or just moved somewhere else.

[rlarocque, 2014-06-10 17:18:30]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-06-10 17:20:42]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/319223002/20001

[commit-bot: I haz the power, 2014-06-10 23:02:33]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  ios_rel_device_ninja on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/ios_rel_device_ninja/...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)

[commit-bot: I haz the power, 2014-06-10 23:11:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-10 23:11:54]

Try jobs failed on following builders:
  android_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  linux_chromium_chromeos_clang_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_chrome...)

[rlarocque, 2014-06-10 23:22:38]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-06-10 23:24:13]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/319223002/40001

[commit-bot: I haz the power, 2014-06-11 09:15:27]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[commit-bot: I haz the power, 2014-06-11 09:21:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-11 09:21:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[rlarocque, 2014-06-11 20:07:32]

+Tim for components/signin approval.

An approval from an owner of that directory should be all we need for this patch
to sail through the CQ.  But I won't submit it until I hear back about
https://codereview.chromium.org/327243003/.

[tim (not reviewing), 2014-06-12 18:02:38]

On 2014/06/11 20:07:32, rlarocque wrote:
> +Tim for components/signin approval.
> 
> An approval from an owner of that directory should be all we need for this
patch
> to sail through the CQ.  But I won't submit it until I hear back about
> https://codereview.chromium.org/327243003/.

I don't see any files in components/signin.  Which file?

[rlarocque, 2014-06-12 18:09:26]

On 2014/06/12 18:02:38, timsteele wrote:
> On 2014/06/11 20:07:32, rlarocque wrote:
> > +Tim for components/signin approval.
> > 
> > An approval from an owner of that directory should be all we need for this
> patch
> > to sail through the CQ.  But I won't submit it until I hear back about
> > https://codereview.chromium.org/327243003/.
> 
> I don't see any files in components/signin.  Which file?

https://codereview.chromium.org/319223002/diff/60001/components/invalidation/...

The pre-submit bot requires your approval because of an added dependency.

[tim (not reviewing), 2014-06-12 18:11:34]

signin/ dep LGTM

[rlarocque, 2014-06-12 18:12:09]

The CQ bit was checked by rlarocque@chromium.org

[commit-bot: I haz the power, 2014-06-12 18:13:50]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/rlarocque@chromium.org/319223002/60001

[bartfab (slow), 2014-06-12 18:15:29]

On 2014/06/12 18:13:50, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-status.appspot.com/cq/rlarocque@chromium.org/319223002/60001

https://codereview.chromium.org/327243003/ just landed. You will have to rebase,
sorry :(.

[rlarocque, 2014-06-12 18:32:08]

On 2014/06/12 18:15:29, bartfab wrote:
> On 2014/06/12 18:13:50, I haz the power (commit-bot) wrote:
> > CQ is trying da patch. Follow status at
> > 
https://chromium-status.appspot.com/cq/rlarocque@chromium.org/319223002/60001
> 
> https://codereview.chromium.org/327243003/ just landed. You will have to
rebase,
> sorry :(.

Already done.  I rebased and re-uploaded as soon as your patch landed.

[commit-bot: I haz the power, 2014-06-12 22:50:57]

Change committed as 276838