Source/core/html/HTMLMediaElement.h - Issue 319213002: Fix MediaSource.duration setter behavior to match the current spec.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/HTMLMediaElement.h

Issue 319213002: Fix MediaSource.duration setter behavior to match the current spec. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebase Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/http/tests/media/media-source/mediasource-remove.html ('K') | « LayoutTests/http/tests/media/media-source/mediasource-remove-expected.txt ('k') | Source/core/html/HTMLMediaElement.cpp » ('j') | Source/core/html/HTMLMediaElement.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/html/HTMLMediaElement.h

diff --git a/Source/core/html/HTMLMediaElement.h b/Source/core/html/HTMLMediaElement.h

index d4215242070c5d682c36ef2575492a0445d7f713..0e7773b61a7f9791c21d432fbc20c14aba327aab 100644

--- a/Source/core/html/HTMLMediaElement.h

+++ b/Source/core/html/HTMLMediaElement.h

@@ -149,7 +149,7 @@ public:

// media source extensions

void closeMediaSource();

- void durationChanged(double duration);

+ void durationChanged(double duration, bool requestSeek);

// controls

bool controls() const;

@@ -346,7 +346,8 @@ private:

void startProgressEventTimer();

void stopPeriodicTimers();

- void seek(double time, ExceptionState&);

+ enum SeekSkipPermission { SkipAllowed, SkipNotAllowed};

+ void seek(SeekSkipPermission, double time, ExceptionState&);

void finishSeek();

void checkIfSeekNeeded();

void addPlayedRange(double start, double end);