Fix MediaSource.duration setter behavior to match the current spec.

Source/modules/mediasource/MediaSource.cpp

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 340 matching lines @@
 
     // 2. If the readyState attribute is not "open" then throw an InvalidStateError
     // exception and abort these steps.
     // 3. If the updating attribute equals true on any SourceBuffer in sourceBuffers,
     // then throw an InvalidStateError exception and abort these steps.
     if (throwExceptionIfClosedOrUpdating(isOpen(), isUpdating(), exceptionState))
         return;
 
     // 4. Run the duration change algorithm with new duration set to the value being
     // assigned to this attribute.
-    // Synchronously process duration change algorithm to enforce any required
-    // seek is started prior to returning.
-    m_attachedElement->durationChanged(duration);
-    m_webMediaSource->setDuration(duration);
+    durationChangeAlgorithm(duration);
+}
+
+void MediaSource::durationChangeAlgorithm(double newDuration)
+{
+    // Section 2.6.4 Duration change
+    // https://dvcs.w3.org/hg/html-media/raw-file/default/media-source/media-source.html#duration-change-algorithm
+    // 1. If the current value of duration is equal to new duration, then return.
+    if (newDuration == duration())
+        return;
+
+    // 2. Set old duration to the current value of duration.
+    double oldDuration = duration();
+
+    bool requestSeek = m_attachedElement->currentTime() > newDuration;
+
+    // 3. Update duration to new duration.
+    m_webMediaSource->setDuration(newDuration);
+
+    // 4. If the new duration is less than old duration, then call remove(new duration, old duration) on all all objects in sourceBuffers.
+    if (newDuration < oldDuration) {
+        for (size_t i = 0; i < m_sourceBuffers->length(); ++i)
+            m_sourceBuffers->item(i)->remove(newDuration, oldDuration, ASSERT_NO_EXCEPTION);
+    }
+
+    // 5. If a user agent is unable to partially render audio frames or text cues that start before and end after the duration, then run the following steps:
+    // NOTE: Currently we assume that the media engine is able to render partial frames/cues. If a media
+    // engine gets added that doesn't support this, then we'll need to add logic to handle the substeps.
+
+    // 6. Update the media controller duration to new duration and run the HTMLMediaElement duration change algorithm.

[philipj_slow, 2014/06/16 13:26:19]

Spec nit: The "media controller duration" is a calculated attribute defined in
terms of the slaved elements, I'm not sure what it means to set it. I think the
"media resource end position" is the appropriate concept here.

[acolwell GONE FROM CHROMIUM, 2014/06/17 01:24:02]

Good point. I'll update the spec.

+    m_attachedElement->durationChanged(newDuration, requestSeek);
 }
 
 void MediaSource::setReadyState(const AtomicString& state)
 {
     ASSERT(state == openKeyword() || state == closedKeyword() || state == endedKeyword());
 
     AtomicString oldState = readyState();
     WTF_LOG(Media, "MediaSource::setReadyState() %p : %s -> %s", this, oldState.ascii().data(), state.ascii().data());
 
     if (state == closedKeyword()) {
@@ skipping 141 matching lines @@
 
     m_asyncEventQueue->enqueueEvent(event.release());
 }
 
 URLRegistry& MediaSource::registry() const
 {
     return MediaSourceRegistry::registry();
 }
 
 } // namespace WebCore