Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 319203003: Change repaintRectIncludingDescendants to repaintRectIncludingNonCompositingDescendants. (Closed)

Created:
6 years, 6 months ago by chrishtr
Modified:
6 years, 6 months ago
Visibility:
Public.

Description

Change repaintRectIncludingDescendants to repaintRectIncludingNonCompositingDescendants. In other words, don't recurse into composited descendants. In all cases, the callers of repaintRectIncludingDescendants only want to update repaint rects for child layers that paint into the same backing. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175807

Patch Set 1 #

Patch Set 2 : Fix. #

Patch Set 3 : Merged. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -7 lines) Patch
M Source/core/frame/FrameView.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderLayerRepainter.cpp View 1 chunk +5 lines, -3 lines 0 comments Download
M Source/core/rendering/compositing/CompositedLayerMapping.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/compositing/RenderLayerCompositor.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
chrishtr
6 years, 6 months ago (2014-06-06 17:44:28 UTC) #1
Ian Vollick
On 2014/06/06 17:44:28, chrishtr wrote: Those layout test failures look unrelated. I've just started some ...
6 years, 6 months ago (2014-06-07 02:22:23 UTC) #2
Ian Vollick
On 2014/06/07 02:22:23, Ian Vollick wrote: > On 2014/06/06 17:44:28, chrishtr wrote: > > > ...
6 years, 6 months ago (2014-06-07 04:09:46 UTC) #3
abarth-chromium
No test?
6 years, 6 months ago (2014-06-07 09:07:39 UTC) #4
chrishtr
No, no test. This CL is just optimizing the code to not do unnecessary work.
6 years, 6 months ago (2014-06-09 16:42:25 UTC) #5
abarth-chromium
On 2014/06/09 at 16:42:25, chrishtr wrote: > No, no test. This CL is just optimizing ...
6 years, 6 months ago (2014-06-09 16:43:22 UTC) #6
chrishtr
The CQ bit was checked by chrishtr@chromium.org
6 years, 6 months ago (2014-06-09 16:43:33 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/chrishtr@chromium.org/319203003/40001
6 years, 6 months ago (2014-06-09 16:44:44 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-09 17:47:36 UTC) #9
Message was sent while issue was closed.
Change committed as 175807

Powered by Google App Engine
This is Rietveld 408576698