Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1114)

Unified Diff: chrome/browser/safe_browsing/safe_browsing_blocking_page.h

Issue 319193002: Update the malware interstitial to have the new layout (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Pre-review style fixes Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/safe_browsing/safe_browsing_blocking_page.h
diff --git a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
index 43ac464b57d8d2d4d8769e630e575e4fd5cf2d53..c3e4b23ad5732c2db14d7e99bebba3ed3a1f7c4e 100644
--- a/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
+++ b/chrome/browser/safe_browsing/safe_browsing_blocking_page.h
@@ -280,6 +280,25 @@ class SafeBrowsingBlockingPageV2 : public SafeBrowsingBlockingPage {
DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPageV2);
};
+class SafeBrowsingBlockingPageV3 : public SafeBrowsingBlockingPage {
Bernhard Bauer 2014/06/09 10:04:03 If this class isn't meant to be directly instantia
felt 2014/06/09 14:24:09 I copied the pattern the pattern that's already in
Bernhard Bauer 2014/06/09 14:45:41 If you don't mind shaving some yak, it would be a
felt 2014/06/09 15:24:02 I moved the V3 one into an anonymous namespace. I'
Bernhard Bauer 2014/06/09 15:43:00 Awesome, thanks!
+ public:
+ // Don't instantiate this class directly, use ShowBlockingPage instead.
+ SafeBrowsingBlockingPageV3(SafeBrowsingUIManager* ui_manager,
+ content::WebContents* web_contents,
+ const UnsafeResourceList& unsafe_resources);
+
+ // InterstitialPageDelegate method:
+ virtual std::string GetHTMLContents() OVERRIDE;
+
+ private:
+ // Fills the passed dictionary with the values to be passed to the template
+ // when creating the HTML.
+ void PopulateMalwareLoadTimeData(base::DictionaryValue* load_time_data);
+ void PopulatePhishingLoadTimeData(base::DictionaryValue* load_time_data);
+
+ DISALLOW_COPY_AND_ASSIGN(SafeBrowsingBlockingPageV3);
+};
+
// Factory for creating SafeBrowsingBlockingPage. Useful for tests.
class SafeBrowsingBlockingPageFactory {
public:

Powered by Google App Engine
This is Rietveld 408576698