Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 319183007: Oilpan: move MessageChannel to the heap. (Closed)

Created:
6 years, 6 months ago by sof
Modified:
6 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, arv+blink, sof, eae+blinkwatch, abarth-chromium, falken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-bindings_chromium.org, Inactive, kinuko+worker_chromium.org, horo+watch_chromium.org, watchdog-blink-watchlist_google.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -6 lines) Patch
M Source/bindings/v8/custom/V8MessageChannelCustom.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/MessageChannel.h View 2 chunks +10 lines, -4 lines 0 comments Download
M Source/core/dom/MessageChannel.cpp View 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/dom/MessageChannel.idl View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/workers/SharedWorker.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
sof
Please take a look.
6 years, 6 months ago (2014-06-07 05:36:35 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-07 06:15:42 UTC) #2
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 6 months ago (2014-06-07 06:27:06 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/319183007/1
6 years, 6 months ago (2014-06-07 06:27:45 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 07:33:54 UTC) #5
Message was sent while issue was closed.
Change committed as 175739

Powered by Google App Engine
This is Rietveld 408576698