Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Side by Side Diff: Source/web/WebPagePopupImpl.cpp

Issue 319183004: Prefer to forward-declare GraphicsContext in headers. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: schenney nit (pare down platform/geometry/ includes to *Rect.h) Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.cpp ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 25 matching lines...) Expand all
36 #include "core/frame/LocalFrame.h" 36 #include "core/frame/LocalFrame.h"
37 #include "core/frame/Settings.h" 37 #include "core/frame/Settings.h"
38 #include "core/loader/EmptyClients.h" 38 #include "core/loader/EmptyClients.h"
39 #include "core/loader/FrameLoadRequest.h" 39 #include "core/loader/FrameLoadRequest.h"
40 #include "core/page/Chrome.h" 40 #include "core/page/Chrome.h"
41 #include "core/page/DOMWindowPagePopup.h" 41 #include "core/page/DOMWindowPagePopup.h"
42 #include "core/page/EventHandler.h" 42 #include "core/page/EventHandler.h"
43 #include "core/page/FocusController.h" 43 #include "core/page/FocusController.h"
44 #include "core/page/Page.h" 44 #include "core/page/Page.h"
45 #include "core/page/PagePopupClient.h" 45 #include "core/page/PagePopupClient.h"
46 #include "platform/TraceEvent.h"
46 #include "public/platform/WebCursorInfo.h" 47 #include "public/platform/WebCursorInfo.h"
47 #include "public/web/WebViewClient.h" 48 #include "public/web/WebViewClient.h"
48 #include "public/web/WebWidgetClient.h" 49 #include "public/web/WebWidgetClient.h"
49 #include "web/WebInputEventConversion.h" 50 #include "web/WebInputEventConversion.h"
50 #include "web/WebSettingsImpl.h" 51 #include "web/WebSettingsImpl.h"
51 #include "web/WebViewImpl.h" 52 #include "web/WebViewImpl.h"
52 53
53 using namespace WebCore; 54 using namespace WebCore;
54 using namespace std; 55 using namespace std;
55 56
(...skipping 346 matching lines...) Expand 10 before | Expand all | Expand 10 after
402 // A WebPagePopupImpl instance usually has two references. 403 // A WebPagePopupImpl instance usually has two references.
403 // - One owned by the instance itself. It represents the visible widget. 404 // - One owned by the instance itself. It represents the visible widget.
404 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the 405 // - One owned by a WebViewImpl. It's released when the WebViewImpl ask the
405 // WebPagePopupImpl to close. 406 // WebPagePopupImpl to close.
406 // We need them because the closing operation is asynchronous and the widget 407 // We need them because the closing operation is asynchronous and the widget
407 // can be closed while the WebViewImpl is unaware of it. 408 // can be closed while the WebViewImpl is unaware of it.
408 return adoptRef(new WebPagePopupImpl(client)).leakRef(); 409 return adoptRef(new WebPagePopupImpl(client)).leakRef();
409 } 410 }
410 411
411 } // namespace blink 412 } // namespace blink
OLDNEW
« no previous file with comments | « Source/web/WebDevToolsAgentImpl.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698