Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Issue 319183002: Fixed sporadic ICU initialization error in content_browsertests. (Closed)

Created:
6 years, 6 months ago by Victor Starodub
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, darin-cc_chromium.org, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fixed sporadic ICU initialization error in content_browsertests. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276391

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M content/test/content_test_launcher.cc View 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Victor Starodub
I've had some issues with sporadic double initialization of ICU when running tests on my ...
6 years, 6 months ago (2014-06-06 16:46:00 UTC) #1
sky
content_browstests has base::i18n::AllowMultipleInitializeCallsForTesting already and content_main_runner has base::i18n::InitializeICU(). What specific tests are you seeing this ...
6 years, 6 months ago (2014-06-06 19:38:33 UTC) #2
Victor Starodub
On 2014/06/06 19:38:33, sky wrote: > content_browstests has base::i18n::AllowMultipleInitializeCallsForTesting > already and content_main_runner has base::i18n::InitializeICU(). ...
6 years, 6 months ago (2014-06-09 15:29:30 UTC) #3
sky
LGTM
6 years, 6 months ago (2014-06-09 16:08:58 UTC) #4
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 6 months ago (2014-06-09 16:31:35 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/319183002/1
6 years, 6 months ago (2014-06-09 16:33:10 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 08:37:27 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 12:25:52 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150231)
6 years, 6 months ago (2014-06-10 12:25:53 UTC) #9
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 6 months ago (2014-06-10 14:23:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/319183002/1
6 years, 6 months ago (2014-06-10 14:27:50 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium ...
6 years, 6 months ago (2014-06-10 15:00:00 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-10 15:30:57 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/builds/150388)
6 years, 6 months ago (2014-06-10 15:30:58 UTC) #14
Victor Starodub
The CQ bit was checked by starodub@google.com
6 years, 6 months ago (2014-06-11 14:20:25 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/319183002/1
6 years, 6 months ago (2014-06-11 14:21:45 UTC) #16
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 14:36:02 UTC) #17
Message was sent while issue was closed.
Change committed as 276391

Powered by Google App Engine
This is Rietveld 408576698