|
|
Created:
6 years, 6 months ago by Victor Starodub Modified:
6 years, 6 months ago Reviewers:
sky CC:
chromium-reviews, darin-cc_chromium.org, jam Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
DescriptionFixed sporadic ICU initialization error in content_browsertests.
BUG=
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276391
Patch Set 1 #
Messages
Total messages: 17 (0 generated)
I've had some issues with sporadic double initialization of ICU when running tests on my machine. Looks like this fix is good enough for content_browsertests.
content_browstests has base::i18n::AllowMultipleInitializeCallsForTesting already and content_main_runner has base::i18n::InitializeICU(). What specific tests are you seeing this in?
On 2014/06/06 19:38:33, sky wrote: > content_browstests has base::i18n::AllowMultipleInitializeCallsForTesting > already and content_main_runner has base::i18n::InitializeICU(). What specific > tests are you seeing this in? Most of the DownloadContentTest.*, e.g. DownloadContentTest.DownloadCancelled. It looks like on Android content_main_runner is not used for the main process, but rather BrowserMainRunner is invoked directly from BrowserTestBase::SetUp(), so those tests might've worked just because something else initializes ICU before it's used in tests (we've got at least one more InitializeICU() method in v8).
LGTM
The CQ bit was checked by starodub@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/319183002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...) linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
The CQ bit was checked by starodub@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/319183002/1
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_clang_dbg on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_clang_dbg/bui...)
The CQ bit was checked by starodub@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/starodub@google.com/319183002/1
Message was sent while issue was closed.
Change committed as 276391 |