Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(121)

Issue 319153002: Effectively unlimited linking. (Closed)

Created:
6 years, 6 months ago by mtklein_C
Modified:
6 years, 6 months ago
Reviewers:
borenet, mtklein
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Effectively unlimited linking. Ninja will still cap concurrency with it's default value (from -j), so we just need a big number equal or greater than the number of cores in any machine. BUG=skia: Committed: https://skia.googlesource.com/skia/+/2e44b51b9a3da1d57328055c4189bf2fa5187e35

Patch Set 1 #

Patch Set 2 : comma #

Total comments: 2

Patch Set 3 : 80col #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -0 lines) Patch
M gyp_skia View 1 2 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
mtklein
If this blows up, we can bring the number down.
6 years, 6 months ago (2014-06-06 14:22:51 UTC) #1
borenet
LGTM. https://codereview.chromium.org/319153002/diff/20001/gyp_skia File gyp_skia (right): https://codereview.chromium.org/319153002/diff/20001/gyp_skia#newcode138 gyp_skia:138: # We don't need to be nearly as ...
6 years, 6 months ago (2014-06-06 15:00:30 UTC) #2
mtklein
The CQ bit was checked by mtklein@google.com
6 years, 6 months ago (2014-06-06 15:03:24 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/mtklein@chromium.org/319153002/40001
6 years, 6 months ago (2014-06-06 15:03:35 UTC) #4
mtklein
https://codereview.chromium.org/319153002/diff/20001/gyp_skia File gyp_skia (right): https://codereview.chromium.org/319153002/diff/20001/gyp_skia#newcode138 gyp_skia:138: # We don't need to be nearly as conservative ...
6 years, 6 months ago (2014-06-06 15:03:35 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 15:27:11 UTC) #6
Message was sent while issue was closed.
Change committed as 2e44b51b9a3da1d57328055c4189bf2fa5187e35

Powered by Google App Engine
This is Rietveld 408576698