Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1257)

Issue 319133010: Switch Display to use ResourceProvider and *Renderer directly. (Closed)

Created:
6 years, 6 months ago by jbauman
Modified:
6 years, 6 months ago
Reviewers:
jamesr
CC:
chromium-reviews, cc-bugs_chromium.org
Visibility:
Public.

Description

Switch Display to use ResourceProvider and *Renderer directly. This removes the dependency on LayerTreeHost, which was a layering violation. BUG=378549 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276329

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Total comments: 1

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+141 lines, -96 lines) Patch
M cc/surfaces/display.h View 1 2 3 3 chunks +31 lines, -40 lines 0 comments Download
M cc/surfaces/display.cc View 1 2 3 4 5 3 chunks +110 lines, -56 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
jbauman
6 years, 6 months ago (2014-06-07 00:55:05 UTC) #1
jamesr
https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc File cc/surfaces/display.cc (right): https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#newcode58 cc/surfaces/display.cc:58: scoped_ptr<OutputSurface> output_surface = client_->CreateOutputSurface(); this block is long enough ...
6 years, 6 months ago (2014-06-09 02:39:27 UTC) #2
jbauman
On 2014/06/09 02:39:27, jamesr wrote: > https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc > File cc/surfaces/display.cc (right): > > https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#newcode58 > ...
6 years, 6 months ago (2014-06-09 20:52:01 UTC) #3
jbauman
PTAL On 2014/06/09 02:39:27, jamesr wrote: > https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc > File cc/surfaces/display.cc (right): > > https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#newcode58 ...
6 years, 6 months ago (2014-06-10 23:37:13 UTC) #4
jamesr
lgtm https://codereview.chromium.org/319133010/diff/60001/cc/surfaces/display.cc File cc/surfaces/display.cc (right): https://codereview.chromium.org/319133010/diff/60001/cc/surfaces/display.cc#newcode19 cc/surfaces/display.cc:19: static ResourceProvider::ResourceId ResourceRemapHelper( nit: blank line between namespace ...
6 years, 6 months ago (2014-06-10 23:38:55 UTC) #5
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 6 months ago (2014-06-10 23:40:37 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/319133010/80001
6 years, 6 months ago (2014-06-10 23:42:08 UTC) #7
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 6 months ago (2014-06-11 00:00:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/319133010/100001
6 years, 6 months ago (2014-06-11 00:02:57 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-11 10:15:15 UTC) #10
Message was sent while issue was closed.
Change committed as 276329

Powered by Google App Engine
This is Rietveld 408576698