Switch Display to use ResourceProvider and *Renderer directly.

Switch Display to use ResourceProvider and *Renderer directly.

This removes the dependency on LayerTreeHost, which was a layering violation.

BUG=378549
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276329

[jamesr, 2014-06-09 02:39:27]

https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc
File cc/surfaces/display.cc (right):

https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
cc/surfaces/display.cc:58: scoped_ptr<OutputSurface> output_surface =
client_->CreateOutputSurface();
this block is long enough to be its own function

https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
cc/surfaces/display.cc:116: resource_provider_->ReceiveFromChild(child_id_,
frame_data->resource_list);
i've got another patch in the queue that does the resource mgmt

https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
cc/surfaces/display.cc:153: void Display::DeferredInitialize() {
could these all be inline? the clang checker should allow empty inline virtuals

[jbauman, 2014-06-09 20:52:01]

On 2014/06/09 02:39:27, jamesr wrote:
> https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc
> File cc/surfaces/display.cc (right):
> 
>
https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
> cc/surfaces/display.cc:58: scoped_ptr<OutputSurface> output_surface =
> client_->CreateOutputSurface();
> this block is long enough to be its own function
> 
>
https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
> cc/surfaces/display.cc:116: resource_provider_->ReceiveFromChild(child_id_,
> frame_data->resource_list);
> i've got another patch in the queue that does the resource mgmt

Ok, cool. I guess I'll wait for that to land.
> 
>
https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
> cc/surfaces/display.cc:153: void Display::DeferredInitialize() {
> could these all be inline? the clang checker should allow empty inline
virtuals

[jbauman, 2014-06-10 23:37:13]

PTAL

On 2014/06/09 02:39:27, jamesr wrote:
> https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc
> File cc/surfaces/display.cc (right):
> 
>
https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
> cc/surfaces/display.cc:58: scoped_ptr<OutputSurface> output_surface =
> client_->CreateOutputSurface();
> this block is long enough to be its own function

fixed
> 
>
https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
> cc/surfaces/display.cc:116: resource_provider_->ReceiveFromChild(child_id_,
> frame_data->resource_list);
> i've got another patch in the queue that does the resource mgmt
> 
>
https://codereview.chromium.org/319133010/diff/40001/cc/surfaces/display.cc#n...
> cc/surfaces/display.cc:153: void Display::DeferredInitialize() {
> could these all be inline? the clang checker should allow empty inline
virtuals
fixed

[jamesr, 2014-06-10 23:38:55]

lgtm

https://codereview.chromium.org/319133010/diff/60001/cc/surfaces/display.cc
File cc/surfaces/display.cc (right):

https://codereview.chromium.org/319133010/diff/60001/cc/surfaces/display.cc#n...
cc/surfaces/display.cc:19: static ResourceProvider::ResourceId
ResourceRemapHelper(
nit: blank line between namespace and function

[jbauman, 2014-06-10 23:40:37]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-06-10 23:42:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/319133010/80001

[jbauman, 2014-06-11 00:00:49]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-06-11 00:02:57]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/319133010/100001

[commit-bot: I haz the power, 2014-06-11 10:15:15]

Change committed as 276329