Issue 319133007: Documented that the new nodes at the root aren't meant to sync.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 319133007: Documented that the new nodes at the root aren't meant to sync. (Closed)

Created:
6 years, 6 months ago by Joao da Silva

Modified:
6 years, 6 months ago

Reviewers:
Andrew T Wilson (Slow)

CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Documented that the new nodes at the root aren't meant to sync. The BookmarkClient can now provide additional nodes to the root of the BookmarkModel, which are optional. Currently none of those nodes should sync; this change makes that intention explicit in the bookmarks sync glue code. BUG=49598 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276346

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -0 lines)			Patch
	M	chrome/browser/sync/glue/bookmark_change_processor.cc	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	chrome/browser/sync/glue/bookmark_model_associator.cc	View		3 chunks	+8 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/319133007/1

6 years, 6 months ago (2014-06-10 23:00:28 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...

6 years, 6 months ago (2014-06-11 09:09:21 UTC) #5

Message was sent while issue was closed.

Change committed as 276346

Expand Messages | Collapse Messages