chrome/browser/devtools/devtools_network_conditions.cc - Issue 319133002: DevToolsManagerDelegate: parse all "emulateNetworkConditions" parameters

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/devtools/devtools_network_conditions.cc

Issue 319133002: DevToolsManagerDelegate: parse all "emulateNetworkConditions" parameters (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix win-gpu compiler warning Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/devtools/devtools_network_conditions.h ('k') | chrome/browser/devtools/devtools_network_controller_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/devtools/devtools_network_conditions.cc

diff --git a/chrome/browser/devtools/devtools_network_conditions.cc b/chrome/browser/devtools/devtools_network_conditions.cc

index aa656c7b8200fcb979d998b3a90cfe4ee889be92..59e06b879c1f54f94fed26d1c4273f46a736a5c4 100644

--- a/chrome/browser/devtools/devtools_network_conditions.cc

+++ b/chrome/browser/devtools/devtools_network_conditions.cc

@@ -7,8 +7,10 @@

#include "url/gurl.h"

DevToolsNetworkConditions::DevToolsNetworkConditions(

- const std::vector<std::string>& domains)

- : domains_(domains){

+ const std::vector<std::string>& domains,

+ double maximal_throughput)

+ : domains_(domains),

+ maximal_throughput_(maximal_throughput) {

}

DevToolsNetworkConditions::~DevToolsNetworkConditions() {

@@ -26,5 +28,9 @@ bool DevToolsNetworkConditions::HasMatchingDomain(const GURL& url) const {

}

bool DevToolsNetworkConditions::IsOffline() const {

- return true;

+ return maximal_throughput_ == 0.0;

+bool DevToolsNetworkConditions::IsThrottling() const {

+ return maximal_throughput_ != 0.0;

}