DevToolsManagerDelegate: parse all "emulateNetworkConditions" parameters

DevToolsManagerDelegate: parse all "emulateNetworkConditions" parameters

BUG=245436
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275680

[vsevik, 2014-06-06 13:56:54]

lgtm

https://codereview.chromium.org/319133002/diff/1/chrome/browser/devtools/chro...
File chrome/browser/devtools/chrome_devtools_manager_delegate.cc (right):

https://codereview.chromium.org/319133002/diff/1/chrome/browser/devtools/chro...
chrome/browser/devtools/chrome_devtools_manager_delegate.cc:110: if
(maximal_throughput < 0.0)
nit: I think negative throughput value is actually correct in terms of protocol
(it is a number as required). I don't think we should do semantic checks during
parsing.
We could simply ignore negative throughput values.

[eustas, 2014-06-06 14:48:12]

https://codereview.chromium.org/319133002/diff/1/chrome/browser/devtools/chro...
File chrome/browser/devtools/chrome_devtools_manager_delegate.cc (right):

https://codereview.chromium.org/319133002/diff/1/chrome/browser/devtools/chro...
chrome/browser/devtools/chrome_devtools_manager_delegate.cc:110: if
(maximal_throughput < 0.0)
On 2014/06/06 13:56:54, vsevik wrote:
> nit: I think negative throughput value is actually correct in terms of
protocol
> (it is a number as required). I don't think we should do semantic checks
during
> parsing.
> We could simply ignore negative throughput values.

Done.

[eustas, 2014-06-06 14:48:36]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-06-06 14:49:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/319133002/20001

[commit-bot: I haz the power, 2014-06-06 17:54:21]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/17031)

[commit-bot: I haz the power, 2014-06-06 17:56:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-06 17:56:50]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/bu...)

[eustas, 2014-06-06 19:23:09]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-06-06 19:26:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/319133002/20001

[eustas, 2014-06-06 20:02:41]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-06-06 20:03:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/319133002/40001

[commit-bot: I haz the power, 2014-06-07 00:32:11]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_chromium_compile_dbg on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_compile_...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)
  win_chromium_x64_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/17203)

[commit-bot: I haz the power, 2014-06-07 01:26:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-07 01:26:41]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/17282)

[eustas, 2014-06-07 12:11:28]

The CQ bit was checked by eustas@chromium.org

[commit-bot: I haz the power, 2014-06-07 12:12:07]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/eustas@chromium.org/319133002/60001

[commit-bot: I haz the power, 2014-06-07 14:27:06]

Change committed as 275680