Chromium Code Reviews Chromium Code Reviews
Issue
319083003:
Use the same fake User-Agent string as GetContentShell()->GetUserAgent() for URLRequestContext in c… (Closed)
DescriptionUse the same fake User-Agent string as GetContentShell()->GetUserAgent() for URLRequestContext in content_shell
ShellContentClient::GetUserAgent() returns a fake User-Agent. It's used
for navigator.userAgent, loading layout test test case file, etc. But
ShellURLRequestContextGetter has an HttpUserAgentSettings with an empty
string for User-Agent. Factor out the code to build the fake User-Agent
from ShellContentClient::GetUserAgent() into GetShellUserAgent() and use
it for ShellURLRequestContextGetter. This is almost the same as how
ChromeShellContentClient and ChromeURLRequestContextGetter are doing.
With this, we can test that WebSocket handshake request contains the
correct user-agent header value.
BUG=347109
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275673
Patch Set 1 #
Messages
Total messages: 7 (0 generated)
|
|||||||||||||||||||||||||||||||||||||
