Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1182)

Unified Diff: content/browser/browser_main_runner.cc

Issue 319053006: Calling Shutdown() for Android content_browsertests. Removed webrtc test hack. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed review comments. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/browser_main_runner.cc
diff --git a/content/browser/browser_main_runner.cc b/content/browser/browser_main_runner.cc
index 16309dec8460af490e891e47ace869c483d258c5..c41fc9541c982949b4e338e4dead6a4005c91616 100644
--- a/content/browser/browser_main_runner.cc
+++ b/content/browser/browser_main_runner.cc
@@ -149,7 +149,12 @@ class BrowserMainRunnerImpl : public BrowserMainRunner {
#if defined(OS_WIN)
ole_initializer_.reset(NULL);
#endif
-
+ #if defined(OS_ANDROID)
+ // Forcefully terminates the RunLoop inside MessagePumpForUI, ensuring
+ // proper shutdown for content_browsertests. Shutdown() is not used by
+ // the actual browser.
+ base::MessageLoop::current()->QuitNow();
jam 2014/06/13 17:14:01 can we avoid putting the test-only code in this no
Victor Starodub 2014/06/17 00:53:04 FYI: the code is not actually test-specific. It's
+ #endif
main_loop_.reset(NULL);
notification_service_.reset(NULL);

Powered by Google App Engine
This is Rietveld 408576698