GM/bench for text draws with various parameters and clip rects.

GM/bench for text draws with various parameters and clip rects.

Committed: https://skia.googlesource.com/skia/+/7c5c9da436194c75d91797f114a87a6119ca255d

[bsalomon, 2014-06-09 14:24:51]

ping

[robertphillips, 2014-06-09 14:42:42]

lgtm + nits/suggestions

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp
File gm/variedtext.cpp (right):

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcode22
gm/variedtext.cpp:22: , fLCD(lcd) {
memset?

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcode72
gm/variedtext.cpp:72: for (int j = 0; j < length; ++j) {
'!', 'z' ? Don't really know which is better.

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcod...
gm/variedtext.cpp:150: 
Line these guys up ?

[jvanverth1, 2014-06-09 14:43:28]

lgtm + nit

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp
File gm/variedtext.cpp (right):

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcod...
gm/variedtext.cpp:140: virtual uint32_t onGetFlags() const SK_OVERRIDE{
Nit: space between SK_OVERRIDE and {

[bsalomon, 2014-06-09 16:55:25]

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp
File gm/variedtext.cpp (right):

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcode22
gm/variedtext.cpp:22: , fLCD(lcd) {
On 2014/06/09 14:42:42, robertphillips wrote:
> memset?

Done.

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcode72
gm/variedtext.cpp:72: for (int j = 0; j < length; ++j) {
On 2014/06/09 14:42:42, robertphillips wrote:
> '!', 'z' ? Don't really know which is better.

Done.

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcod...
gm/variedtext.cpp:140: virtual uint32_t onGetFlags() const SK_OVERRIDE{
On 2014/06/09 14:43:28, jvanverth1 wrote:
> Nit: space between SK_OVERRIDE and {

Done.

https://codereview.chromium.org/319053002/diff/60001/gm/variedtext.cpp#newcod...
gm/variedtext.cpp:150: 
On 2014/06/09 14:42:42, robertphillips wrote:
> Line these guys up ?

Done.

[bsalomon, 2014-06-09 16:55:30]

The CQ bit was checked by bsalomon@google.com

[bsalomon, 2014-06-09 18:17:28]

The CQ bit was unchecked by bsalomon@google.com

[bsalomon, 2014-06-09 18:17:30]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-06-09 18:18:25]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/319053002/100001

[commit-bot: I haz the power, 2014-06-09 18:53:56]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Mac10.8-Clang-x86-Release-Trybot/b...)
  Build-Ubuntu13.10-Clang-x86_64-Debug-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-Clang-x86_64-Debug-Try...)
  Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Android-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-Arm7-Debug-Andr...)
  Build-Ubuntu13.10-GCC4.8-x86_64-Release-Trybot on tryserver.chromium
(http://108.170.220.76:10117/builders/Build-Ubuntu13.10-GCC4.8-x86_64-Release-...)
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.chromium
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[commit-bot: I haz the power, 2014-06-09 19:30:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-09 19:30:46]

Try jobs failed on following builders:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.chromium
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[bsalomon, 2014-06-09 19:31:18]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-06-09 19:32:05]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/319053002/120001

[commit-bot: I haz the power, 2014-06-09 21:14:29]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-Debug-Trybot on tryserver.chromium
(http://108.170.220.120:10117/builders/Test-Ubuntu13.10-ShuttleA-NoGPU-x86_64-...)

[bsalomon, 2014-06-09 21:17:09]

The CQ bit was checked by bsalomon@google.com

[commit-bot: I haz the power, 2014-06-09 21:17:20]

CQ is trying da patch. Follow status at
 https://skia-tree-status.appspot.com/cq/bsalomon@google.com/319053002/140001

[commit-bot: I haz the power, 2014-06-09 22:11:35]

Change committed as 7c5c9da436194c75d91797f114a87a6119ca255d