Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(525)

Unified Diff: chrome/browser/ui/views/constrained_window_views_browsertest.cc

Issue 319013002: Reland Fix Views web-modal dialog widget creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert MediaGalleriesScanResultDialogViews::AcceptDialogForTesting. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/constrained_window_views_browsertest.cc
diff --git a/chrome/browser/ui/views/constrained_window_views_browsertest.cc b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
index 5f5ac696913dd222b8ec4839df988a9a4f4f1235..9b1bfd8328d8ad3c58b4c441325bccd8207f6652 100644
--- a/chrome/browser/ui/views/constrained_window_views_browsertest.cc
+++ b/chrome/browser/ui/views/constrained_window_views_browsertest.cc
@@ -2,6 +2,8 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include "chrome/browser/ui/views/constrained_window_views.h"
+
#include "base/memory/scoped_ptr.h"
#include "chrome/browser/ui/browser.h"
#include "chrome/browser/ui/browser_commands.h"
@@ -51,10 +53,7 @@ class TestDialog : public views::DialogDelegateView {
// A helper function to create and show a web contents modal dialog.
scoped_ptr<TestDialog> ShowModalDialog(content::WebContents* web_contents) {
scoped_ptr<TestDialog> dialog(new TestDialog());
- views::Widget* window = views::Widget::CreateWindowAsFramelessChild(
- dialog.get(), web_contents->GetNativeView());
- web_modal::WebContentsModalDialogManager::FromWebContents(web_contents)->
- ShowModalDialog(window->GetNativeView());
+ ShowWebModalDialogViews(dialog.get(), web_contents);
return dialog.Pass();
}
« no previous file with comments | « chrome/browser/ui/views/constrained_window_views.cc ('k') | chrome/browser/ui/views/desktop_media_picker_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698