Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: chrome/browser/ui/views/signed_certificate_timestamps_views.cc

Issue 319013002: Reland Fix Views web-modal dialog widget creation. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Revert MediaGalleriesScanResultDialogViews::AcceptDialogForTesting. Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/signed_certificate_timestamps_views.h" 5 #include "chrome/browser/ui/views/signed_certificate_timestamps_views.h"
6 6
7 #include "base/strings/string_number_conversions.h" 7 #include "base/strings/string_number_conversions.h"
8 #include "base/strings/stringprintf.h" 8 #include "base/strings/stringprintf.h"
9 #include "base/strings/utf_string_conversions.h" 9 #include "base/strings/utf_string_conversions.h"
10 #include "chrome/browser/chrome_notification_types.h" 10 #include "chrome/browser/chrome_notification_types.h"
11 #include "chrome/browser/ui/views/constrained_window_views.h" 11 #include "chrome/browser/ui/views/constrained_window_views.h"
12 #include "chrome/browser/ui/views/signed_certificate_timestamp_info_view.h" 12 #include "chrome/browser/ui/views/signed_certificate_timestamp_info_view.h"
13 #include "components/web_modal/web_contents_modal_dialog_host.h"
14 #include "components/web_modal/web_contents_modal_dialog_manager.h"
15 #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
16 #include "content/public/browser/notification_source.h" 13 #include "content/public/browser/notification_source.h"
17 #include "content/public/browser/signed_certificate_timestamp_store.h" 14 #include "content/public/browser/signed_certificate_timestamp_store.h"
18 #include "content/public/common/signed_certificate_timestamp_id_and_status.h" 15 #include "content/public/common/signed_certificate_timestamp_id_and_status.h"
19 #include "grit/generated_resources.h" 16 #include "grit/generated_resources.h"
20 #include "net/cert/signed_certificate_timestamp.h"
21 #include "net/ssl/signed_certificate_timestamp_and_status.h"
22 #include "ui/base/l10n/l10n_util.h" 17 #include "ui/base/l10n/l10n_util.h"
23 #include "ui/base/models/combobox_model.h" 18 #include "ui/base/models/combobox_model.h"
24 #include "ui/views/controls/combobox/combobox.h" 19 #include "ui/views/controls/combobox/combobox.h"
25 #include "ui/views/layout/grid_layout.h" 20 #include "ui/views/layout/grid_layout.h"
26 #include "ui/views/layout/layout_constants.h" 21 #include "ui/views/layout/layout_constants.h"
27 #include "ui/views/widget/widget.h" 22 #include "ui/views/widget/widget.h"
28 23
29 using web_modal::WebContentsModalDialogManager;
30 using web_modal::WebContentsModalDialogManagerDelegate;
31 using views::GridLayout;
32
33 namespace { 24 namespace {
34 25
35 void SignedCertificateTimestampIDsToList( 26 void SignedCertificateTimestampIDsToList(
36 const content::SignedCertificateTimestampIDStatusList& sct_ids_list, 27 const content::SignedCertificateTimestampIDStatusList& sct_ids_list,
37 net::SignedCertificateTimestampAndStatusList* sct_list) { 28 net::SignedCertificateTimestampAndStatusList* sct_list) {
38 for (content::SignedCertificateTimestampIDStatusList::const_iterator it = 29 for (content::SignedCertificateTimestampIDStatusList::const_iterator it =
39 sct_ids_list.begin(); 30 sct_ids_list.begin();
40 it != sct_ids_list.end(); 31 it != sct_ids_list.end();
41 ++it) { 32 ++it) {
42 scoped_refptr<net::ct::SignedCertificateTimestamp> sct; 33 scoped_refptr<net::ct::SignedCertificateTimestamp> sct;
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 base::IntToString16(index + 1), 89 base::IntToString16(index + 1),
99 base::UTF8ToUTF16(origin), 90 base::UTF8ToUTF16(origin),
100 base::UTF8ToUTF16(status)); 91 base::UTF8ToUTF16(status));
101 } 92 }
102 93
103 SignedCertificateTimestampsViews::SignedCertificateTimestampsViews( 94 SignedCertificateTimestampsViews::SignedCertificateTimestampsViews(
104 content::WebContents* web_contents, 95 content::WebContents* web_contents,
105 const net::SignedCertificateTimestampAndStatusList& sct_list) 96 const net::SignedCertificateTimestampAndStatusList& sct_list)
106 : sct_info_view_(NULL), 97 : sct_info_view_(NULL),
107 sct_list_(sct_list) { 98 sct_list_(sct_list) {
108 WebContentsModalDialogManager* web_contents_modal_dialog_manager = 99 ShowWebModalDialogViews(this, web_contents);
109 WebContentsModalDialogManager::FromWebContents(web_contents);
110 WebContentsModalDialogManagerDelegate* modal_delegate =
111 web_contents_modal_dialog_manager->delegate();
112 DCHECK(modal_delegate);
113 views::Widget* window = views::Widget::CreateWindowAsFramelessChild(
114 this, modal_delegate->GetWebContentsModalDialogHost()->GetHostView());
115 web_contents_modal_dialog_manager->ShowModalDialog(
116 window->GetNativeView());
117 } 100 }
118 101
119 SignedCertificateTimestampsViews::~SignedCertificateTimestampsViews() {} 102 SignedCertificateTimestampsViews::~SignedCertificateTimestampsViews() {}
120 103
121 base::string16 SignedCertificateTimestampsViews::GetWindowTitle() const { 104 base::string16 SignedCertificateTimestampsViews::GetWindowTitle() const {
122 return l10n_util::GetStringUTF16(IDS_SCT_VIEWER_TITLE); 105 return l10n_util::GetStringUTF16(IDS_SCT_VIEWER_TITLE);
123 } 106 }
124 107
125 int SignedCertificateTimestampsViews::GetDialogButtons() const { 108 int SignedCertificateTimestampsViews::GetDialogButtons() const {
126 return ui::DIALOG_BUTTON_CANCEL; 109 return ui::DIALOG_BUTTON_CANCEL;
127 } 110 }
128 111
129 ui::ModalType SignedCertificateTimestampsViews::GetModalType() const { 112 ui::ModalType SignedCertificateTimestampsViews::GetModalType() const {
130 #if defined(USE_ASH)
131 return ui::MODAL_TYPE_CHILD; 113 return ui::MODAL_TYPE_CHILD;
132 #else
133 return views::WidgetDelegate::GetModalType();
134 #endif
135 } 114 }
136 115
137 void SignedCertificateTimestampsViews::OnPerformAction( 116 void SignedCertificateTimestampsViews::OnPerformAction(
138 views::Combobox* combobox) { 117 views::Combobox* combobox) {
139 DCHECK_EQ(combobox, sct_selector_box_.get()); 118 DCHECK_EQ(combobox, sct_selector_box_.get());
140 DCHECK_LT(combobox->selected_index(), sct_list_model_->GetItemCount()); 119 DCHECK_LT(combobox->selected_index(), sct_list_model_->GetItemCount());
141 ShowSCTInfo(combobox->selected_index()); 120 ShowSCTInfo(combobox->selected_index());
142 } 121 }
143 122
144 void SignedCertificateTimestampsViews::ViewHierarchyChanged( 123 void SignedCertificateTimestampsViews::ViewHierarchyChanged(
145 const ViewHierarchyChangedDetails& details) { 124 const ViewHierarchyChangedDetails& details) {
146 if (details.is_add && details.child == this) 125 if (details.is_add && details.child == this)
147 Init(); 126 Init();
148 } 127 }
149 128
150 void SignedCertificateTimestampsViews::Init() { 129 void SignedCertificateTimestampsViews::Init() {
151 GridLayout* layout = GridLayout::CreatePanel(this); 130 views::GridLayout* layout = views::GridLayout::CreatePanel(this);
152 SetLayoutManager(layout); 131 SetLayoutManager(layout);
153 132
154 const int kSelectorBoxLayoutId = 0; 133 const int kSelectorBoxLayoutId = 0;
155 views::ColumnSet* column_set = layout->AddColumnSet(kSelectorBoxLayoutId); 134 views::ColumnSet* column_set = layout->AddColumnSet(kSelectorBoxLayoutId);
156 column_set->AddColumn( 135 column_set->AddColumn(views::GridLayout::FILL, views::GridLayout::FILL, 1,
157 GridLayout::FILL, GridLayout::FILL, 1, GridLayout::USE_PREF, 0, 0); 136 views::GridLayout::USE_PREF, 0, 0);
158 137
159 layout->StartRow(0, kSelectorBoxLayoutId); 138 layout->StartRow(0, kSelectorBoxLayoutId);
160 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing); 139 layout->AddPaddingRow(0, views::kRelatedControlVerticalSpacing);
161 140
162 // Add SCT selector drop-down list. 141 // Add SCT selector drop-down list.
163 layout->StartRow(0, kSelectorBoxLayoutId); 142 layout->StartRow(0, kSelectorBoxLayoutId);
164 sct_list_model_.reset(new SCTListModel(sct_list_)); 143 sct_list_model_.reset(new SCTListModel(sct_list_));
165 sct_selector_box_.reset(new views::Combobox(sct_list_model_.get())); 144 sct_selector_box_.reset(new views::Combobox(sct_list_model_.get()));
166 sct_selector_box_->set_listener(this); 145 sct_selector_box_->set_listener(this);
167 sct_selector_box_->set_owned_by_client(); 146 sct_selector_box_->set_owned_by_client();
(...skipping 16 matching lines...) Expand all
184 sct_info_view_->SetSignedCertificateTimestamp(*(sct_list_[sct_index].sct), 163 sct_info_view_->SetSignedCertificateTimestamp(*(sct_list_[sct_index].sct),
185 sct_list_[sct_index].status); 164 sct_list_[sct_index].status);
186 } 165 }
187 166
188 void SignedCertificateTimestampsViews::Observe( 167 void SignedCertificateTimestampsViews::Observe(
189 int type, 168 int type,
190 const content::NotificationSource& source, 169 const content::NotificationSource& source,
191 const content::NotificationDetails& details) { 170 const content::NotificationDetails& details) {
192 GetWidget()->Close(); 171 GetWidget()->Close();
193 } 172 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/pdf_password_dialog.cc ('k') | chrome/browser/ui/views/ssl_client_certificate_selector.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698