src/effects/SkMatrixConvolutionImageFilter.cpp - Issue 319003002: Adding kernel offset validation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/SkMatrixConvolutionImageFilter.cpp

Issue 319003002: Adding kernel offset validation (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/SkMatrixConvolutionImageFilter.cpp

diff --git a/src/effects/SkMatrixConvolutionImageFilter.cpp b/src/effects/SkMatrixConvolutionImageFilter.cpp

index 8ae837755fe9c8924c07313d1694732ab454fcfd..89e113b8cea9867fb70c99dfcbbe9db532b4718f 100644

--- a/src/effects/SkMatrixConvolutionImageFilter.cpp

+++ b/src/effects/SkMatrixConvolutionImageFilter.cpp

@@ -86,7 +86,9 @@ SkMatrixConvolutionImageFilter::SkMatrixConvolutionImageFilter(SkReadBuffer& buf

buffer.validate((fKernel != 0) &&

SkScalarIsFinite(fGain) &&

SkScalarIsFinite(fBias) &&

- tile_mode_is_valid(fTileMode));

+ tile_mode_is_valid(fTileMode) &&

+ (fKernelOffset.fX >= 0) && (fKernelOffset.fX < fKernelSize.fWidth) &&

+ (fKernelOffset.fY >= 0) && (fKernelOffset.fY < fKernelSize.fHeight));

}

void SkMatrixConvolutionImageFilter::flatten(SkWriteBuffer& buffer) const {

« no previous file with comments | « no previous file | no next file » | no next file with comments »