Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 318993003: Install Google Slides and Sheets apps by default. (Closed)

Created:
6 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
6 years, 6 months ago
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Visibility:
Public.

Description

Install Google Slides and Sheets apps by default. This affects only official Chrome builds. BUG=374279 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275433

Patch Set 1 #

Patch Set 2 : better #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M chrome/browser/extensions/external_provider_impl.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/default_apps/external_extensions.json View 1 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Ken Rockot(use gerrit already)
Antony, could you take a look?
6 years, 6 months ago (2014-06-05 18:32:55 UTC) #1
asargent_no_longer_on_chrome
This makes them external component apps, which means they -can't be uninstalled -won't show up ...
6 years, 6 months ago (2014-06-05 19:56:03 UTC) #2
Ken Rockot(use gerrit already)
On 2014/06/05 19:56:03, Antony Sargent wrote: > This makes them external component apps, which means ...
6 years, 6 months ago (2014-06-06 00:15:01 UTC) #3
asargent_no_longer_on_chrome
lgtm
6 years, 6 months ago (2014-06-06 03:04:10 UTC) #4
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 6 months ago (2014-06-06 03:25:49 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/318993003/20001
6 years, 6 months ago (2014-06-06 03:26:36 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_dbg_triggered_tests on tryserver.chromium ...
6 years, 6 months ago (2014-06-06 07:49:31 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-06 08:55:22 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/builds/39178)
6 years, 6 months ago (2014-06-06 08:55:23 UTC) #9
Ken Rockot(use gerrit already)
The CQ bit was checked by rockot@chromium.org
6 years, 6 months ago (2014-06-06 12:52:12 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rockot@chromium.org/318993003/20001
6 years, 6 months ago (2014-06-06 12:52:54 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 13:57:26 UTC) #12
Message was sent while issue was closed.
Change committed as 275433

Powered by Google App Engine
This is Rietveld 408576698