Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318993002: Merge MetricsLog and MetricsLogBase. (Closed)

Created:
6 years, 6 months ago by Alexei Svitkine (slow)
Modified:
6 years, 6 months ago
Reviewers:
Ilya Sherman, blundell
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, Ilya Sherman, extensions-reviews_chromium.org, asvitkine+watch_chromium.org, jar+watch_chromium.org
Visibility:
Public.

Description

Merge MetricsLog and MetricsLogBase. BUG=374209 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275586

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : rebase #

Patch Set 5 : Fix compile #

Patch Set 6 : Fix test #

Total comments: 6

Patch Set 7 : #

Patch Set 8 : address nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+430 lines, -496 lines) Patch
M chrome/browser/metrics/extensions_metrics_provider.cc View 1 2 3 4 5 6 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/metrics/metrics_service.cc View 1 2 3 4 5 6 6 chunks +6 lines, -15 lines 0 comments Download
M chrome/browser/metrics/metrics_service_unittest.cc View 1 2 3 4 5 6 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/metrics/omnibox_metrics_provider.cc View 1 2 3 4 5 6 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/metrics/profiler_metrics_provider.cc View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download
M components/components_tests.gyp View 1 2 3 4 5 6 2 chunks +2 lines, -1 line 0 comments Download
M components/metrics.gypi View 1 2 3 4 5 6 1 chunk +0 lines, -2 lines 0 comments Download
M components/metrics/metrics_log.h View 1 2 3 4 5 6 7 5 chunks +62 lines, -5 lines 0 comments Download
M components/metrics/metrics_log.cc View 1 2 3 4 5 6 7 6 chunks +114 lines, -9 lines 0 comments Download
D components/metrics/metrics_log_base.h View 1 2 3 4 5 6 1 chunk +0 lines, -103 lines 0 comments Download
D components/metrics/metrics_log_base.cc View 1 2 3 4 5 6 1 chunk +0 lines, -138 lines 0 comments Download
D components/metrics/metrics_log_base_unittest.cc View 1 2 3 4 5 6 1 chunk +0 lines, -122 lines 0 comments Download
M components/metrics/metrics_log_manager.h View 1 2 3 4 5 6 4 chunks +6 lines, -8 lines 0 comments Download
M components/metrics/metrics_log_manager.cc View 1 2 3 4 5 6 4 chunks +7 lines, -6 lines 0 comments Download
M components/metrics/metrics_log_manager_unittest.cc View 1 2 3 4 5 6 17 chunks +77 lines, -70 lines 0 comments Download
A components/metrics/metrics_log_unittest.cc View 1 2 3 4 5 1 chunk +134 lines, -0 lines 0 comments Download
M components/metrics/test_metrics_service_client.h View 1 2 3 4 5 6 1 chunk +4 lines, -0 lines 0 comments Download
M components/metrics/test_metrics_service_client.cc View 1 2 3 4 5 6 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Alexei Svitkine (slow)
6 years, 6 months ago (2014-06-05 18:27:17 UTC) #1
blundell
Looks good. Ilya, could you make sure to take a detailed look over the code ...
6 years, 6 months ago (2014-06-06 08:21:47 UTC) #2
Ilya Sherman
LGTM. Looks great! Thank, Alexei :) https://codereview.chromium.org/318993002/diff/100001/components/metrics/metrics_log.cc File components/metrics/metrics_log.cc (right): https://codereview.chromium.org/318993002/diff/100001/components/metrics/metrics_log.cc#newcode109 components/metrics/metrics_log.cc:109: uma_proto_.set_client_id(Hash(client_id)); Optional nit: ...
6 years, 6 months ago (2014-06-06 19:37:01 UTC) #3
Alexei Svitkine (slow)
https://codereview.chromium.org/318993002/diff/100001/components/metrics/metrics_log.cc File components/metrics/metrics_log.cc (right): https://codereview.chromium.org/318993002/diff/100001/components/metrics/metrics_log.cc#newcode109 components/metrics/metrics_log.cc:109: uma_proto_.set_client_id(Hash(client_id)); On 2014/06/06 19:37:01, Ilya Sherman wrote: > Optional ...
6 years, 6 months ago (2014-06-06 21:45:42 UTC) #4
Alexei Svitkine (slow)
The CQ bit was checked by asvitkine@chromium.org
6 years, 6 months ago (2014-06-06 21:45:47 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/asvitkine@chromium.org/318993002/140001
6 years, 6 months ago (2014-06-06 21:50:17 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-07 01:54:06 UTC) #7
Message was sent while issue was closed. 
Change committed as 275586

Powered by Google App Engine
This is Rietveld 408576698