Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 318983003: requestAutocomplete: Actually log the console message instead of dropping it on the floor (Closed)

Created:
6 years, 6 months ago by Evan Stade
Modified:
6 years, 6 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, benquan, jam, browser-components-watch_chromium.org, darin-cc_chromium.org, Dane Wallinga, dyu1, estade+watch_chromium.org, Ilya Sherman, rouslan+autofillwatch_chromium.org
Visibility:
Public.

Description

requestAutocomplete: Actually log the console message instead of dropping it on the floor BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275371

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M components/autofill/content/renderer/autofill_agent.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
6 years, 6 months ago (2014-06-05 22:16:45 UTC) #1
Dan Beam
lgtm (the world would <3 you more with a test, though)
6 years, 6 months ago (2014-06-05 22:17:22 UTC) #2
Evan Stade
The CQ bit was checked by estade@chromium.org
6 years, 6 months ago (2014-06-05 22:19:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/estade@chromium.org/318983003/1
6 years, 6 months ago (2014-06-05 22:20:57 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 10:16:43 UTC) #5
Message was sent while issue was closed.
Change committed as 275371

Powered by Google App Engine
This is Rietveld 408576698