Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(212)

Issue 318983002: Use parseDirectives were possible. Also mark analyzer ready to be released. (Closed)

Created:
6 years, 6 months ago by Siggi Cherem (dart-lang)
Modified:
6 years, 6 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use parseDirectives were possible. Also mark analyzer ready to be released. R=blois@google.com, brianwilkerson@google.com, jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=37063

Patch Set 1 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+56 lines, -85 lines) Patch
M pkg/analyzer/pubspec.yaml View 1 chunk +1 line, -1 line 1 comment Download
M pkg/code_transformers/lib/src/dart_sdk.dart View 2 chunks +1 line, -16 lines 0 comments Download
M pkg/code_transformers/lib/src/resolver_impl.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/code_transformers/pubspec.yaml View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/observe/lib/transformer.dart View 3 chunks +2 lines, -16 lines 0 comments Download
M pkg/observe/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/lib/src/build/common.dart View 1 chunk +0 lines, -16 lines 0 comments Download
M pkg/polymer/lib/src/build/import_inliner.dart View 10 chunks +38 lines, -22 lines 0 comments Download
M pkg/polymer/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/polymer/test/build/code_extractor.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M pkg/polymer/test/build/import_inliner_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/smoke/pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Siggi Cherem (dart-lang)
https://codereview.chromium.org/318983002/diff/20001/pkg/analyzer/pubspec.yaml File pkg/analyzer/pubspec.yaml (right): https://codereview.chromium.org/318983002/diff/20001/pkg/analyzer/pubspec.yaml#newcode2 pkg/analyzer/pubspec.yaml:2: version: 0.15.6 Brian - would it be OK if ...
6 years, 6 months ago (2014-06-05 17:41:51 UTC) #1
Brian Wilkerson
analysis engine change LGTM
6 years, 6 months ago (2014-06-05 18:25:01 UTC) #2
blois
lgtm
6 years, 6 months ago (2014-06-05 18:25:45 UTC) #3
Jennifer Messerly
lgtm
6 years, 6 months ago (2014-06-06 01:42:16 UTC) #4
Siggi Cherem (dart-lang)
6 years, 6 months ago (2014-06-06 02:04:27 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r37063 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698