src/effects/gradients/SkTwoPointConicalGradient.h - Issue 318923005: SkShader::asNewEffect Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkTwoPointConicalGradient.h

Issue 318923005: SkShader::asNewEffect Refactoring (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Style corrections Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkTwoPointConicalGradient.h

diff --git a/src/effects/gradients/SkTwoPointConicalGradient.h b/src/effects/gradients/SkTwoPointConicalGradient.h

index 78998a8d98ada974a6fe3b48bcd322d1fd6d78f8..9e35d758eeda580df3b31fca5bb9b9502cd8159a 100644

--- a/src/effects/gradients/SkTwoPointConicalGradient.h

+++ b/src/effects/gradients/SkTwoPointConicalGradient.h

@@ -65,7 +65,8 @@ public:

SkMatrix* matrix,

TileMode* xy) const;

virtual SkShader::GradientType asAGradient(GradientInfo* info) const SK_OVERRIDE;

- virtual GrEffectRef* asNewEffect(GrContext*, const SkPaint&, const SkMatrix*) const SK_OVERRIDE;

+ virtual bool asNewEffect(GrContext*, const SkPaint&, GrColor* grColor, GrEffectRef**,

+ const SkMatrix*) const SK_OVERRIDE;

virtual bool isOpaque() const SK_OVERRIDE;

SkScalar getCenterX1() const { return SkPoint::Distance(fCenter1, fCenter2); }