src/effects/gradients/SkRadialGradient.h - Issue 318923005: SkShader::asNewEffect Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/effects/gradients/SkRadialGradient.h

Issue 318923005: SkShader::asNewEffect Refactoring (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Style corrections Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/effects/gradients/SkRadialGradient.h

diff --git a/src/effects/gradients/SkRadialGradient.h b/src/effects/gradients/SkRadialGradient.h

index aade31ef524886eaf514e5d09b21fd8d372e4268..9ebc5411d3bd821ec4e9a647792f83fe77e13ea1 100644

--- a/src/effects/gradients/SkRadialGradient.h

+++ b/src/effects/gradients/SkRadialGradient.h

@@ -33,7 +33,8 @@ public:

SkMatrix* matrix,

TileMode* xy) const SK_OVERRIDE;

virtual GradientType asAGradient(GradientInfo* info) const SK_OVERRIDE;

- virtual GrEffectRef* asNewEffect(GrContext*, const SkPaint&, const SkMatrix*) const SK_OVERRIDE;

+ virtual bool asNewEffect(GrContext*, const SkPaint&, GrColor*, GrEffectRef**, const SkMatrix*)

+ const SK_OVERRIDE;

jvanverth1 2014/06/05 17:03:07 Indent.

dandov 2014/06/06 21:50:43 Done.

SK_TO_STRING_OVERRIDE()

SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkRadialGradient)