src/core/SkBitmapProcShader.h - Issue 318923005: SkShader::asNewEffect Refactoring

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/core/SkBitmapProcShader.h

Issue 318923005: SkShader::asNewEffect Refactoring (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Style corrections Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/core/SkBitmapProcShader.h

diff --git a/src/core/SkBitmapProcShader.h b/src/core/SkBitmapProcShader.h

index 80e4550279ea2a1d8a8ad2630d28587a8b6b9f46..eaf69f201776d04ea8723837cf55d6ab750f4494 100644

--- a/src/core/SkBitmapProcShader.h

+++ b/src/core/SkBitmapProcShader.h

@@ -31,7 +31,8 @@ public:

SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkBitmapProcShader)

#if SK_SUPPORT_GPU

jvanverth1 2014/06/05 17:36:31 Given that the base class asNewEffect() definition

dandov 2014/06/06 21:50:43 I didn't change this because I wanted to first tes

- GrEffectRef* asNewEffect(GrContext*, const SkPaint&, const SkMatrix*) const SK_OVERRIDE;

+ bool asNewEffect(GrContext*, const SkPaint&, GrColor*, GrEffectRef**, const SkMatrix*)

+ const SK_OVERRIDE;

#endif

class BitmapProcShaderContext : public SkShader::Context {