src/core/SkPictureShader.h - Issue 318923005: SkShader::asNewEffect Refactoring

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: src/core/SkPictureShader.h

Issue 318923005: SkShader::asNewEffect Refactoring (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Style corrections Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 /*	1 /*

2 * Copyright 2014 Google Inc.	2 * Copyright 2014 Google Inc.

3 *	3 *

4 * Use of this source code is governed by a BSD-style license that can be	4 * Use of this source code is governed by a BSD-style license that can be

5 * found in the LICENSE file.	5 * found in the LICENSE file.

6 */	6 */

7	7

8 #ifndef SkPictureShader_DEFINED	8 #ifndef SkPictureShader_DEFINED

9 #define SkPictureShader_DEFINED	9 #define SkPictureShader_DEFINED

10	10

(...skipping 12 matching lines...) Expand all Loading...
23 public:	23 public:

24 static SkPictureShader* Create(SkPicture, TileMode, TileMode, const SkMatri x = NULL);	24 static SkPictureShader* Create(SkPicture, TileMode, TileMode, const SkMatri x = NULL);

25 virtual ~SkPictureShader();	25 virtual ~SkPictureShader();

26	26

27 virtual size_t contextSize() const SK_OVERRIDE;	27 virtual size_t contextSize() const SK_OVERRIDE;

28	28

29 SK_TO_STRING_OVERRIDE()	29 SK_TO_STRING_OVERRIDE()

30 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkPictureShader)	30 SK_DECLARE_PUBLIC_FLATTENABLE_DESERIALIZATION_PROCS(SkPictureShader)

31	31

32 #if SK_SUPPORT_GPU	32 #if SK_SUPPORT_GPU

33 GrEffectRef* asNewEffect(GrContext, const SkPaint&, const SkMatrix) const SK_OVERRIDE;	33 bool asNewEffect(GrContext, const SkPaint&, GrColor, GrEffectRef*, const SkMatrix)

	34 const SK_OVERRIDE;
	jvanverth1 2014/06/05 17:36:31 indent indent dandov 2014/06/06 21:50:43 Done. Show quoted text On 2014/06/05 17:36:31, jvanverth1 wrote: > indent Done.
34 #endif	35 #endif

35	36

36 protected:	37 protected:

37 SkPictureShader(SkReadBuffer&);	38 SkPictureShader(SkReadBuffer&);

38 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;	39 virtual void flatten(SkWriteBuffer&) const SK_OVERRIDE;

39 virtual Context* onCreateContext(const ContextRec&, void* storage) const SK_ OVERRIDE;	40 virtual Context* onCreateContext(const ContextRec&, void* storage) const SK_ OVERRIDE;

40	41

41 private:	42 private:

42 SkPictureShader(SkPicture, TileMode, TileMode, const SkMatrix = NULL);	43 SkPictureShader(SkPicture, TileMode, TileMode, const SkMatrix = NULL);

43	44

(...skipping 27 matching lines...) Expand all Loading...
71 SkShader::Context* fBitmapShaderContext;	72 SkShader::Context* fBitmapShaderContext;

72 void* fBitmapShaderContextStorage;	73 void* fBitmapShaderContextStorage;

73	74

74 typedef SkShader::Context INHERITED;	75 typedef SkShader::Context INHERITED;

75 };	76 };

76	77

77 typedef SkShader INHERITED;	78 typedef SkShader INHERITED;

78 };	79 };

79	80

80 #endif // SkPictureShader_DEFINED	81 #endif // SkPictureShader_DEFINED

OLD	NEW

« src/core/SkBitmapProcShader.cpp ('K') | « src/core/SkLocalMatrixShader.h ('k') | src/core/SkPictureShader.cpp » ('j') | src/effects/SkPerlinNoiseShader.cpp » ('J')