Source/web/WebMediaPlayerClientImpl.cpp - Issue 318923004: Eliminate MediaPlayer & MediaPlayerClient abstractions(readystate)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/web/WebMediaPlayerClientImpl.cpp

Issue 318923004: Eliminate MediaPlayer & MediaPlayerClient abstractions(readystate) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fixed review comments Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/web/WebMediaPlayerClientImpl.cpp

diff --git a/Source/web/WebMediaPlayerClientImpl.cpp b/Source/web/WebMediaPlayerClientImpl.cpp

index d1039e7d90107520c51d8f2d9fe1df4f91213ad7..a7a645833cc94c38c3aa7a1cf28b77d42abd4c2b 100644

--- a/Source/web/WebMediaPlayerClientImpl.cpp

+++ b/Source/web/WebMediaPlayerClientImpl.cpp

@@ -224,13 +224,6 @@ MediaPlayer::NetworkState WebMediaPlayerClientImpl::networkState() const

return MediaPlayer::Empty;

}

-MediaPlayer::ReadyState WebMediaPlayerClientImpl::readyState() const

- if (m_webMediaPlayer)

- return static_cast<MediaPlayer::ReadyState>(m_webMediaPlayer->readyState());

- return MediaPlayer::HaveNothing;

double WebMediaPlayerClientImpl::maxTimeSeekable() const

{

if (m_webMediaPlayer)

« no previous file with comments | « Source/web/WebMediaPlayerClientImpl.h ('k') | no next file » | no next file with comments »