Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Side by Side Diff: Source/modules/imagebitmap/ImageBitmapFactories.cpp

Issue 318923004: Eliminate MediaPlayer & MediaPlayerClient abstractions(readystate) (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fixed review comments Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/platform/graphics/media/MediaPlayer.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2013, Google Inc. All rights reserved. 2 * Copyright (c) 2013, Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 106 matching lines...) Expand 10 before | Expand all | Expand 10 after
117 { 117 {
118 IntSize s = sizeFor(video); 118 IntSize s = sizeFor(video);
119 return createImageBitmap(scriptState, eventTarget, video, 0, 0, s.width(), s .height(), exceptionState); 119 return createImageBitmap(scriptState, eventTarget, video, 0, 0, s.width(), s .height(), exceptionState);
120 } 120 }
121 121
122 ScriptPromise ImageBitmapFactories::createImageBitmap(ScriptState* scriptState, EventTarget& eventTarget, HTMLVideoElement* video, int sx, int sy, int sw, int s h, ExceptionState& exceptionState) 122 ScriptPromise ImageBitmapFactories::createImageBitmap(ScriptState* scriptState, EventTarget& eventTarget, HTMLVideoElement* video, int sx, int sy, int sw, int s h, ExceptionState& exceptionState)
123 { 123 {
124 // This variant does not work in worker threads. 124 // This variant does not work in worker threads.
125 ASSERT(eventTarget.toDOMWindow()); 125 ASSERT(eventTarget.toDOMWindow());
126 126
127 if (!video->player()) {
128 exceptionState.throwDOMException(InvalidStateError, "No player can be re trieved from the provided video element.");
129 return ScriptPromise();
130 }
131 if (video->networkState() == HTMLMediaElement::NETWORK_EMPTY) { 127 if (video->networkState() == HTMLMediaElement::NETWORK_EMPTY) {
132 exceptionState.throwDOMException(InvalidStateError, "The provided elemen t has not retrieved data."); 128 exceptionState.throwDOMException(InvalidStateError, "The provided elemen t has not retrieved data.");
133 return ScriptPromise(); 129 return ScriptPromise();
134 } 130 }
135 if (video->player()->readyState() <= MediaPlayer::HaveMetadata) { 131 if (video->readyState() <= HTMLMediaElement::HAVE_METADATA) {
136 exceptionState.throwDOMException(InvalidStateError, "The provided elemen t's player has no current data."); 132 exceptionState.throwDOMException(InvalidStateError, "The provided elemen t's player has no current data.");
137 return ScriptPromise(); 133 return ScriptPromise();
138 } 134 }
139 if (!sw || !sh) { 135 if (!sw || !sh) {
140 exceptionState.throwDOMException(IndexSizeError, String::format("The sou rce %s provided is 0.", sw ? "height" : "width")); 136 exceptionState.throwDOMException(IndexSizeError, String::format("The sou rce %s provided is 0.", sw ? "height" : "width"));
141 return ScriptPromise(); 137 return ScriptPromise();
142 } 138 }
143 if (!video->hasSingleSecurityOrigin()) { 139 if (!video->hasSingleSecurityOrigin()) {
144 exceptionState.throwSecurityError("The source video contains image data from multiple origins."); 140 exceptionState.throwSecurityError("The source video contains image data from multiple origins.");
145 return ScriptPromise(); 141 return ScriptPromise();
146 } 142 }
147 if (!(video->webMediaPlayer() && video->webMediaPlayer()->didPassCORSAccessC heck()) 143 if (!video->webMediaPlayer()->didPassCORSAccessCheck()
148 && eventTarget.toDOMWindow()->document()->securityOrigin()->taintsCanvas (video->currentSrc())) { 144 && eventTarget.toDOMWindow()->document()->securityOrigin()->taintsCanvas (video->currentSrc())) {
149 exceptionState.throwSecurityError("Cross-origin access to the source vid eo is denied."); 145 exceptionState.throwSecurityError("Cross-origin access to the source vid eo is denied.");
150 return ScriptPromise(); 146 return ScriptPromise();
151 } 147 }
152 // FIXME: make ImageBitmap creation asynchronous crbug.com/258082 148 // FIXME: make ImageBitmap creation asynchronous crbug.com/258082
153 return fulfillImageBitmap(scriptState, ImageBitmap::create(video, IntRect(sx , sy, sw, sh))); 149 return fulfillImageBitmap(scriptState, ImageBitmap::create(video, IntRect(sx , sy, sw, sh)));
154 } 150 }
155 151
156 ScriptPromise ImageBitmapFactories::createImageBitmap(ScriptState* scriptState, EventTarget& eventTarget, CanvasRenderingContext2D* context, ExceptionState& exc eptionState) 152 ScriptPromise ImageBitmapFactories::createImageBitmap(ScriptState* scriptState, EventTarget& eventTarget, CanvasRenderingContext2D* context, ExceptionState& exc eptionState)
157 { 153 {
(...skipping 177 matching lines...) Expand 10 before | Expand all | Expand 10 after
335 { 331 {
336 rejectPromise(); 332 rejectPromise();
337 } 333 }
338 334
339 void ImageBitmapFactories::ImageBitmapLoader::trace(Visitor* visitor) 335 void ImageBitmapFactories::ImageBitmapLoader::trace(Visitor* visitor)
340 { 336 {
341 visitor->trace(m_factory); 337 visitor->trace(m_factory);
342 } 338 }
343 339
344 } // namespace WebCore 340 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/html/HTMLMediaElement.cpp ('k') | Source/platform/graphics/media/MediaPlayer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698