Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 318913002: Fix BrowserActionButton displaying pressed state when mouse is out. There are some special case… (Closed)

Created:
6 years, 6 months ago by Xuefei Ren
Modified:
6 years, 6 months ago
Reviewers:
Robert Sesek, Finnur, mehmet
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Fix BrowserActionButton displaying pressed state when mouse is out. There are some special cases that will cause button still can receive mouse down event when mouse is out of the button area. One is right click out of the button and a contextual menu comes out. If double click now, BrowserActionButton can still receive the event. Therefore we don't handle it in this case. BUG=377676 R=rsesek@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275397

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M chrome/browser/ui/cocoa/extensions/browser_action_button.mm View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Xuefei Ren
Hi there, Would you take a look. Thanks.
6 years, 6 months ago (2014-06-05 06:05:43 UTC) #1
Finnur
Thanks! This looks fine to me, but I think it would be better if a ...
6 years, 6 months ago (2014-06-05 16:41:03 UTC) #2
Robert Sesek
LGTM
6 years, 6 months ago (2014-06-05 17:17:20 UTC) #3
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 6 months ago (2014-06-06 00:59:17 UTC) #4
Xuefei Ren
The CQ bit was unchecked by xrenishere@gmail.com
6 years, 6 months ago (2014-06-06 00:59:30 UTC) #5
Xuefei Ren
The CQ bit was checked by xrenishere@gmail.com
6 years, 6 months ago (2014-06-06 01:00:46 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xrenishere@gmail.com/318913002/1
6 years, 6 months ago (2014-06-06 01:02:27 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 11:13:11 UTC) #8
Message was sent while issue was closed.
Change committed as 275397

Powered by Google App Engine
This is Rietveld 408576698