Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 318893002: Added DeviceDescription::version with Privet version. (Closed)

Created:
6 years, 6 months ago by Vitaly Buka (NO REVIEWS)
Modified:
6 years, 6 months ago
Reviewers:
Noam Samuel
CC:
chromium-reviews
Visibility:
Public.

Description

Added DeviceDescription::version with Privet version. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275318

Patch Set 1 #

Patch Set 2 : Thu 06/05/2014 11:30:37.29 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -6 lines) Patch
M chrome/browser/local_discovery/device_description.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/device_description.cc View 1 3 chunks +13 lines, -1 line 0 comments Download
M chrome/browser/local_discovery/privet_constants.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_constants.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/local_discovery/privet_device_lister.h View 1 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/local_discovery/privet_device_lister.cc View 1 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Vitaly Buka (NO REVIEWS)
6 years, 6 months ago (2014-06-05 05:25:07 UTC) #1
Noam Samuel
lgtm Maybe it makes sense to add code that rewrites version 2 as 1 so ...
6 years, 6 months ago (2014-06-05 18:28:24 UTC) #2
Vitaly Buka (NO REVIEWS)
The CQ bit was checked by vitalybuka@chromium.org
6 years, 6 months ago (2014-06-05 18:34:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalybuka@chromium.org/318893002/20001
6 years, 6 months ago (2014-06-05 18:35:37 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: mac_chromium_rel on tryserver.chromium ...
6 years, 6 months ago (2014-06-05 22:40:45 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 03:30:13 UTC) #6
Message was sent while issue was closed.
Change committed as 275318

Powered by Google App Engine
This is Rietveld 408576698