Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(265)

Side by Side Diff: chrome/browser/chromeos/drive/change_list_loader.cc

Issue 318873003: drive: Stop returning ResourceList from JobScheduler (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/change_list_processor.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/drive/change_list_loader.h" 5 #include "chrome/browser/chromeos/drive/change_list_loader.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
11 #include "base/metrics/histogram.h" 11 #include "base/metrics/histogram.h"
12 #include "base/strings/string_number_conversions.h" 12 #include "base/strings/string_number_conversions.h"
13 #include "base/time/time.h" 13 #include "base/time/time.h"
14 #include "chrome/browser/chromeos/drive/change_list_loader_observer.h" 14 #include "chrome/browser/chromeos/drive/change_list_loader_observer.h"
15 #include "chrome/browser/chromeos/drive/change_list_processor.h" 15 #include "chrome/browser/chromeos/drive/change_list_processor.h"
16 #include "chrome/browser/chromeos/drive/file_system_util.h" 16 #include "chrome/browser/chromeos/drive/file_system_util.h"
17 #include "chrome/browser/chromeos/drive/job_scheduler.h" 17 #include "chrome/browser/chromeos/drive/job_scheduler.h"
18 #include "chrome/browser/chromeos/drive/resource_metadata.h" 18 #include "chrome/browser/chromeos/drive/resource_metadata.h"
19 #include "chrome/browser/drive/event_logger.h" 19 #include "chrome/browser/drive/event_logger.h"
20 #include "content/public/browser/browser_thread.h" 20 #include "content/public/browser/browser_thread.h"
21 #include "google_apis/drive/drive_api_parser.h" 21 #include "google_apis/drive/drive_api_parser.h"
22 #include "google_apis/drive/gdata_wapi_parser.h"
23 #include "url/gurl.h" 22 #include "url/gurl.h"
24 23
25 using content::BrowserThread; 24 using content::BrowserThread;
26 25
27 namespace drive { 26 namespace drive {
28 namespace internal { 27 namespace internal {
29 28
30 typedef base::Callback<void(FileError, ScopedVector<ChangeList>)> 29 typedef base::Callback<void(FileError, ScopedVector<ChangeList>)>
31 FeedFetcherCallback; 30 FeedFetcherCallback;
32 31
(...skipping 17 matching lines...) Expand all
50 } 49 }
51 50
52 virtual void Run(const FeedFetcherCallback& callback) OVERRIDE { 51 virtual void Run(const FeedFetcherCallback& callback) OVERRIDE {
53 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 52 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
54 DCHECK(!callback.is_null()); 53 DCHECK(!callback.is_null());
55 54
56 // Remember the time stamp for usage stats. 55 // Remember the time stamp for usage stats.
57 start_time_ = base::TimeTicks::Now(); 56 start_time_ = base::TimeTicks::Now();
58 57
59 // This is full resource list fetch. 58 // This is full resource list fetch.
60 scheduler_->GetAllResourceList( 59 scheduler_->GetAllFileList(
61 base::Bind(&FullFeedFetcher::OnFileListFetched, 60 base::Bind(&FullFeedFetcher::OnFileListFetched,
62 weak_ptr_factory_.GetWeakPtr(), callback)); 61 weak_ptr_factory_.GetWeakPtr(), callback));
63 } 62 }
64 63
65 private: 64 private:
66 void OnFileListFetched( 65 void OnFileListFetched(const FeedFetcherCallback& callback,
67 const FeedFetcherCallback& callback, 66 google_apis::GDataErrorCode status,
68 google_apis::GDataErrorCode status, 67 scoped_ptr<google_apis::FileList> file_list) {
69 scoped_ptr<google_apis::ResourceList> resource_list) {
70 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 68 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
71 DCHECK(!callback.is_null()); 69 DCHECK(!callback.is_null());
72 70
73 FileError error = GDataToFileError(status); 71 FileError error = GDataToFileError(status);
74 if (error != FILE_ERROR_OK) { 72 if (error != FILE_ERROR_OK) {
75 callback.Run(error, ScopedVector<ChangeList>()); 73 callback.Run(error, ScopedVector<ChangeList>());
76 return; 74 return;
77 } 75 }
78 76
79 DCHECK(resource_list); 77 DCHECK(file_list);
80 change_lists_.push_back(new ChangeList(*resource_list)); 78 change_lists_.push_back(new ChangeList(*file_list));
81 79
82 GURL next_url; 80 if (!file_list->next_link().is_empty()) {
83 if (resource_list->GetNextFeedURL(&next_url) && !next_url.is_empty()) {
84 // There is the remaining result so fetch it. 81 // There is the remaining result so fetch it.
85 scheduler_->GetRemainingFileList( 82 scheduler_->GetRemainingFileList(
86 next_url, 83 file_list->next_link(),
87 base::Bind(&FullFeedFetcher::OnFileListFetched, 84 base::Bind(&FullFeedFetcher::OnFileListFetched,
88 weak_ptr_factory_.GetWeakPtr(), callback)); 85 weak_ptr_factory_.GetWeakPtr(), callback));
89 return; 86 return;
90 } 87 }
91 88
92 UMA_HISTOGRAM_LONG_TIMES("Drive.FullFeedLoadTime", 89 UMA_HISTOGRAM_LONG_TIMES("Drive.FullFeedLoadTime",
93 base::TimeTicks::Now() - start_time_); 90 base::TimeTicks::Now() - start_time_);
94 91
95 // Note: The fetcher is managed by ChangeListLoader, and the instance 92 // Note: The fetcher is managed by ChangeListLoader, and the instance
96 // will be deleted in the callback. Do not touch the fields after this 93 // will be deleted in the callback. Do not touch the fields after this
(...skipping 24 matching lines...) Expand all
121 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 118 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
122 DCHECK(!callback.is_null()); 119 DCHECK(!callback.is_null());
123 120
124 scheduler_->GetChangeList( 121 scheduler_->GetChangeList(
125 start_change_id_, 122 start_change_id_,
126 base::Bind(&DeltaFeedFetcher::OnChangeListFetched, 123 base::Bind(&DeltaFeedFetcher::OnChangeListFetched,
127 weak_ptr_factory_.GetWeakPtr(), callback)); 124 weak_ptr_factory_.GetWeakPtr(), callback));
128 } 125 }
129 126
130 private: 127 private:
131 void OnChangeListFetched( 128 void OnChangeListFetched(const FeedFetcherCallback& callback,
132 const FeedFetcherCallback& callback, 129 google_apis::GDataErrorCode status,
133 google_apis::GDataErrorCode status, 130 scoped_ptr<google_apis::ChangeList> change_list) {
134 scoped_ptr<google_apis::ResourceList> resource_list) {
135 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 131 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
136 DCHECK(!callback.is_null()); 132 DCHECK(!callback.is_null());
137 133
138 FileError error = GDataToFileError(status); 134 FileError error = GDataToFileError(status);
139 if (error != FILE_ERROR_OK) { 135 if (error != FILE_ERROR_OK) {
140 callback.Run(error, ScopedVector<ChangeList>()); 136 callback.Run(error, ScopedVector<ChangeList>());
141 return; 137 return;
142 } 138 }
143 139
144 DCHECK(resource_list); 140 DCHECK(change_list);
145 change_lists_.push_back(new ChangeList(*resource_list)); 141 change_lists_.push_back(new ChangeList(*change_list));
146 142
147 GURL next_url; 143 if (!change_list->next_link().is_empty()) {
148 if (resource_list->GetNextFeedURL(&next_url) && !next_url.is_empty()) {
149 // There is the remaining result so fetch it. 144 // There is the remaining result so fetch it.
150 scheduler_->GetRemainingChangeList( 145 scheduler_->GetRemainingChangeList(
151 next_url, 146 change_list->next_link(),
152 base::Bind(&DeltaFeedFetcher::OnChangeListFetched, 147 base::Bind(&DeltaFeedFetcher::OnChangeListFetched,
153 weak_ptr_factory_.GetWeakPtr(), callback)); 148 weak_ptr_factory_.GetWeakPtr(), callback));
154 return; 149 return;
155 } 150 }
156 151
157 // Note: The fetcher is managed by ChangeListLoader, and the instance 152 // Note: The fetcher is managed by ChangeListLoader, and the instance
158 // will be deleted in the callback. Do not touch the fields after this 153 // will be deleted in the callback. Do not touch the fields after this
159 // invocation. 154 // invocation.
160 callback.Run(FILE_ERROR_OK, change_lists_.Pass()); 155 callback.Run(FILE_ERROR_OK, change_lists_.Pass());
161 } 156 }
(...skipping 377 matching lines...) Expand 10 before | Expand all | Expand 10 after
539 534
540 OnChangeListLoadComplete(error); 535 OnChangeListLoadComplete(error);
541 536
542 FOR_EACH_OBSERVER(ChangeListLoaderObserver, 537 FOR_EACH_OBSERVER(ChangeListLoaderObserver,
543 observers_, 538 observers_,
544 OnLoadFromServerComplete()); 539 OnLoadFromServerComplete());
545 } 540 }
546 541
547 } // namespace internal 542 } // namespace internal
548 } // namespace drive 543 } // namespace drive
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/change_list_processor.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698