Add support for JSON output to checkperms.py

Add support for JSON output to checkperms.py

BUG=99191
R=maruel@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275146

[M-A Ruel, 2014-06-05 15:00:47]

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms.py
File tools/checkperms/checkperms.py (right):

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:304: returns an error if it is inconsistent.
It's not clear that it returns None when there's no error.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:317: 'rel_path': rel_path,
sort keys

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:348: errors = []
This function should be two lines instead of 10:
gen = (check_file(root, f) for f in files if not is_ignored(f))
return filter(None, gen)

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:525: if args:
start_dir = args[0] if args else api.root_dir

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:533: print ('Processed %s files, %d files where
tested for shebang/ELF '
print(' ...

it's a function call now.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:537: with open(options.json, 'w') as f:
'wb'

CR have no place in this world.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:542: print '\n'.join([e['full_path'] for e in
errors])
Remove [], serialization of a generator into a list is unnecessary.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:545: print '\n'.join(['%s: %s' % (e['full_path'],
e['error']) for e in errors])
Same.

[Paweł Hajdan Jr., 2014-06-05 15:43:54]

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms.py
File tools/checkperms/checkperms.py (right):

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:304: returns an error if it is inconsistent.
On 2014/06/05 15:00:47, M-A Ruel wrote:
> It's not clear that it returns None when there's no error.

Done.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:317: 'rel_path': rel_path,
On 2014/06/05 15:00:47, M-A Ruel wrote:
> sort keys

Done.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:348: errors = []
On 2014/06/05 15:00:47, M-A Ruel wrote:
> This function should be two lines instead of 10:
> gen = (check_file(root, f) for f in files if not is_ignored(f))
> return filter(None, gen)

Done.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:525: if args:
On 2014/06/05 15:00:47, M-A Ruel wrote:
> start_dir = args[0] if args else api.root_dir

Done.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:533: print ('Processed %s files, %d files where
tested for shebang/ELF '
On 2014/06/05 15:00:47, M-A Ruel wrote:
> print(' ...
> 
> it's a function call now.

Done.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:537: with open(options.json, 'w') as f:
On 2014/06/05 15:00:47, M-A Ruel wrote:
> 'wb'
> 
> CR have no place in this world.

Keeping 'w' per offline discussion and consistency with other json call sites.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:542: print '\n'.join([e['full_path'] for e in
errors])
On 2014/06/05 15:00:47, M-A Ruel wrote:
> Remove [], serialization of a generator into a list is unnecessary.

Done.

https://codereview.chromium.org/318863006/diff/1/tools/checkperms/checkperms....
tools/checkperms/checkperms.py:545: print '\n'.join(['%s: %s' % (e['full_path'],
e['error']) for e in errors])
On 2014/06/05 15:00:47, M-A Ruel wrote:
> Same.

Done.

[M-A Ruel, 2014-06-05 15:47:39]

lgtm

[Paweł Hajdan Jr., 2014-06-05 16:19:13]

Committed patchset #2 manually as r275146 (presubmit successful).