Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(258)

Issue 318853005: Re-enable unified gesture detector. (Closed)

Created:
6 years, 6 months ago by tdresser
Modified:
6 years, 6 months ago
Reviewers:
sadrul
CC:
chromium-reviews, tdresser+watch_chromium.org
Visibility:
Public.

Description

Re-enable unified gesture detector. Enabled here: https://codereview.chromium.org/315713002/ Disable here: https://codereview.chromium.org/312303003/ BUG=332418 TEST=GestureRecognizerTest.* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276742

Patch Set 1 #

Patch Set 2 : Checking if WindowEventDispatcher hold requests are getting in the way of the test. #

Patch Set 3 : Try removing delay. #

Patch Set 4 : Disable UGR, for testing. #

Patch Set 5 : Add logs for debugging #

Patch Set 6 : Checking if the failure was just the bot in a bad state. #

Patch Set 7 : Add logs for debugging. #

Patch Set 8 : Disable failing tests. #

Patch Set 9 : Fix suppression. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M tools/valgrind/gtest_exclude/ash_unittests.gtest-memcheck.txt View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
A tools/valgrind/gtest_exclude/aura_unittests.gtest-memcheck.txt View 1 2 3 4 5 6 7 8 1 chunk +2 lines, -0 lines 0 comments Download
M ui/events/gestures/gesture_recognizer_impl.cc View 4 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
tdresser
Looks like the valgrind bot was just in a bad state. It appears to be ...
6 years, 6 months ago (2014-06-11 14:22:49 UTC) #1
tdresser
On 2014/06/11 14:22:49, tdresser wrote: > Looks like the valgrind bot was just in a ...
6 years, 6 months ago (2014-06-11 14:25:53 UTC) #2
tdresser
This is ready to go.
6 years, 6 months ago (2014-06-11 17:45:38 UTC) #3
sadrul
events change lgtm The suppression file: adding the WindowTest to ash_unittests sounds like the wrong ...
6 years, 6 months ago (2014-06-11 17:47:50 UTC) #4
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 6 months ago (2014-06-12 12:02:46 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/318853005/160001
6 years, 6 months ago (2014-06-12 12:04:01 UTC) #6
tdresser
The CQ bit was unchecked by tdresser@chromium.org
6 years, 6 months ago (2014-06-12 13:20:30 UTC) #7
tdresser
The CQ bit was checked by tdresser@chromium.org
6 years, 6 months ago (2014-06-12 18:12:31 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tdresser@chromium.org/318853005/160001
6 years, 6 months ago (2014-06-12 18:13:59 UTC) #9
commit-bot: I haz the power
6 years, 6 months ago (2014-06-12 18:17:12 UTC) #10
Message was sent while issue was closed.
Change committed as 276742

Powered by Google App Engine
This is Rietveld 408576698