Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
318833002:
fix sign-compare warning. (Closed)
|
Created:
6 years, 6 months ago by yunlian Modified:
6 years, 6 months ago CC:
chromium-reviews, fischman+watch_chromium.org, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, wjia+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Visibility:
Public. |
Descriptionfix sign-compare warning.
BUG=chromium:373548
TEST=the warnings are gone.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276555
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Messages
Total messages: 34 (0 generated)
https://codereview.chromium.org/318833002/diff/1/content/common/gpu/media/vid... File content/common/gpu/media/video_encode_accelerator_unittest.cc (right): https://codereview.chromium.org/318833002/diff/1/content/common/gpu/media/vid... content/common/gpu/media/video_encode_accelerator_unittest.cc:625: ASSERT_EQ(input_buffer_size_ & 63, static_cast<size_t>(0)) Will 0u work? https://codereview.chromium.org/318833002/diff/1/content/common/gpu/media/vid... content/common/gpu/media/video_encode_accelerator_unittest.cc:628: static_cast<size_t>(0)) ditto
lgtm
lgtm
The CQ bit was checked by yunlian@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/318833002/20001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel/bu...) mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: mac_chromium_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
The CQ bit was checked by yunlian@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/318833002/60001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was checked by yunlian@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/318833002/60001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was checked by yunlian@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/318833002/60001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was checked by yunlian@chromium.org
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/318833002/60001
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_x64_rel on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_x64_rel/...)
The CQ bit was checked by yunlian@google.com
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yunlian@chromium.org/318833002/60001
Message was sent while issue was closed.
Change committed as 276555 |
