Chromium Code Reviews| Index: native_client_sdk/src/build_tools/generate_make.py |
| diff --git a/native_client_sdk/src/build_tools/generate_make.py b/native_client_sdk/src/build_tools/generate_make.py |
| index 45eb9336f89f08c442e3ae5eae4ceedeb76d6758..66f6b76049a222f8918478fe5bdcad005ed2dafb 100644 |
| --- a/native_client_sdk/src/build_tools/generate_make.py |
| +++ b/native_client_sdk/src/build_tools/generate_make.py |
| @@ -153,6 +153,8 @@ def GenerateManifest(srcroot, dstroot, desc): |
| combined_permissions.append({'socket': socket_permissions}) |
| pretty_permissions = json.dumps(combined_permissions, |
| sort_keys=True, indent=4) |
| + version = build_version.ChromeVersionNoTrunk() |
| + min_chrome_version = desc.get('MIN_CHROME_VERSION') |
| replace = { |
| 'name': desc['TITLE'], |
| 'description': '%s Example' % desc['TITLE'], |
| @@ -160,7 +162,8 @@ def GenerateManifest(srcroot, dstroot, desc): |
| 'channel': None, |
| 'permissions': pretty_permissions, |
| 'multi_platform': desc.get('MULTI_PLATFORM', False), |
| - 'version': build_version.ChromeVersionNoTrunk() |
| + 'version': version, |
|
Sam Clegg
2014/06/05 19:33:12
Why have you created this 'version' variable?
binji
2014/06/05 20:22:38
Oh, I was originally using it as the default value
|
| + 'min_chrome_version': min_chrome_version, |
| } |
| RunTemplateFileIfChanged(srcpath, dstpath, replace) |