Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1529)

Unified Diff: Source/core/rendering/RenderObject.h

Issue 318803002: Rename Repaint to Paint Invalidation part 3 (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Rebase to master Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/rendering/RenderObject.h
diff --git a/Source/core/rendering/RenderObject.h b/Source/core/rendering/RenderObject.h
index a3122d838fb44c7d72e9545d9f86881477f1dcc1..9b64859b321cb0bc911d4012ddcf4aa9cd2edba3 100644
--- a/Source/core/rendering/RenderObject.h
+++ b/Source/core/rendering/RenderObject.h
@@ -820,26 +820,27 @@ public:
// Returns the rect bounds needed to repaint this object, in the coordinate space of the rendering backing of |repaintContainer|
LayoutRect boundsRectForRepaint(const RenderLayerModelObject* repaintContainer) const;
- // Actually do the repaint of rect r for this object which has been computed in the coordinate space
- // of repaintContainer. If repaintContainer is 0, repaint via the view.
- void repaintUsingContainer(const RenderLayerModelObject* repaintContainer, const IntRect&, InvalidationReason) const;
+ // Actually do the paint invalidate of rect r for this object which has been computed in the coordinate space
+ // of paintInvalidationContainer. If paintInvalidationContainer is 0, invalidate paints via the view.
+ void invalidatePaintUsingContainer(const RenderLayerModelObject* paintInvalidationContainer, const IntRect&, InvalidationReason) const;
- // Repaint the entire object. Called when, e.g., the color of a border changes, or when a border
+ // Invalidate the paint of the entire object. Called when, e.g., the color of a border changes, or when a border
// style changes.
- void repaint() const;
+ void invalidatePaint() const;
- // Repaint a specific subrectangle within a given object. The rect |r| is in the object's coordinate space.
- void repaintRectangle(const LayoutRect&) const;
+ // Invalidate the paint of a specific subrectangle within a given object. The rect |r| is in the object's coordinate space.
+ void invalidatePaintRectangle(const LayoutRect&) const;
- // Repaint only if our old bounds and new bounds are different. The caller may pass in newBounds if they are known.
- bool repaintAfterLayoutIfNeeded(const RenderLayerModelObject* repaintContainer, bool wasSelfLayout,
- const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromRepaintContainer, const LayoutRect* newBoundsPtr = 0, const LayoutPoint* newPositionFromRepaintContainer = 0);
+ // Invalidate the paint only if our old bounds and new bounds are different. The caller may pass in newBounds if they are known.
+ bool invalidatePaintAfterLayoutIfNeeded(const RenderLayerModelObject* paintInvalidationContainer, bool wasSelfLayout,
+ const LayoutRect& oldBounds, const LayoutPoint& oldPositionFromPaintInvalidationContainer,
+ const LayoutRect* newBoundsPtr = 0, const LayoutPoint* newPositionFromPaintInvalidationContainer = 0);
// Walk the tree after layout issuing paint invalidations for renderers that have changed or moved, updating bounds that have changed, and clearing paint invalidation state.
virtual void invalidateTreeAfterLayout(const RenderLayerModelObject&);
- virtual void repaintOverflow();
- void repaintOverflowIfNeeded();
+ virtual void invalidateOverflowPaint();
Julien - ping for review 2014/06/11 16:27:21 Not a huge fan of this name, how about invalidateP
dsinclair 2014/06/11 17:04:06 Done.
+ void invalidateOverflowPaintIfNeeded();
bool checkForRepaint() const;
bool checkForRepaintDuringLayout() const;

Powered by Google App Engine
This is Rietveld 408576698