Issue 318773006: Revert "V8 can clear exception pending message, when should not do this."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 318773006: Revert "V8 can clear exception pending message, when should not do this." (Closed)

Created:
6 years, 6 months ago by yurys

Modified:
6 years, 6 months ago

Reviewers:
kozyatinskiy1, Yang

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Revert "V8 can clear exception pending message, when should not do this." This reverts commit 2c6665a7a21bd38f3dea28eb9b303f913c69be8d. Broke too many tests. TBR=yangguo@chromium.org BUG=None LOG=N Committed: https://code.google.com/p/v8/source/detail?r=21698

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+21 lines, -61 lines)			Patch
M	src/isolate.h	View	2 chunks	+2 lines, -6 lines	0 comments	Download
M	src/isolate.cc	View	5 chunks	+19 lines, -20 lines	0 comments	Download
M	test/cctest/test-api.cc	View	1 chunk	+0 lines, -35 lines	0 comments	Download

Total messages: 2 (0 generated)

yurys

Committed patchset #1 manually as r21698 (tree was closed).

6 years, 6 months ago (2014-06-05 13:59:07 UTC) #1

Yang

6 years, 6 months ago (2014-06-05 13:59:30 UTC) #2

Message was sent while issue was closed.

On 2014/06/05 13:59:07, yurys wrote:
> Committed patchset #1 manually as r21698 (tree was closed).

lgtm. thanks.