Add tracing output for the name of an input event to Blink.

Add tracing output for the name of an input event to Blink.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175674

[ojan, 2014-06-04 23:05:20]

lgtm

Please remove the empty BUG=. :)

[chrishtr, 2014-06-05 20:31:07]

Updated to output strings instead of numbers.

[ojan, 2014-06-05 21:14:15]

lgtm

https://codereview.chromium.org/318753008/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/318753008/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:1811: static const AtomicString*
inputTypeToName(WebInputEvent::Type type)
Add a FIXME to autogenerate this in EventTypeNames and get rid of the default
clause? Eventually, I want a world in which we have this single function that we
call it everywhere instead of all the one-off that only do a subset of the event
types functions.

[chrishtr, 2014-06-05 21:32:37]

https://codereview.chromium.org/318753008/diff/20001/Source/web/WebViewImpl.cpp
File Source/web/WebViewImpl.cpp (right):

https://codereview.chromium.org/318753008/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:1811: static const AtomicString*
inputTypeToName(WebInputEvent::Type type)
On 2014/06/05 21:14:15, ojan wrote:
> Add a FIXME to autogenerate this in EventTypeNames and get rid of the default
> clause? Eventually, I want a world in which we have this single function that
we
> call it everywhere instead of all the one-off that only do a subset of the
event
> types functions.

Done.

https://codereview.chromium.org/318753008/diff/20001/Source/web/WebViewImpl.c...
Source/web/WebViewImpl.cpp:1811: static const AtomicString*
inputTypeToName(WebInputEvent::Type type)
On 2014/06/05 21:14:15, ojan wrote:
> Add a FIXME to autogenerate this in EventTypeNames and get rid of the default
> clause? Eventually, I want a world in which we have this single function that
we
> call it everywhere instead of all the one-off that only do a subset of the
event
> types functions.

Done.

[chrishtr, 2014-06-05 21:32:41]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-06-05 21:32:59]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/318753008/40001

[commit-bot: I haz the power, 2014-06-05 22:39:06]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/10855)

[chrishtr, 2014-06-05 22:48:29]

The CQ bit was unchecked by chrishtr@chromium.org

[chrishtr, 2014-06-06 16:32:47]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2014-06-06 16:33:54]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/chrishtr@chromium.org/318753008/40001

[commit-bot: I haz the power, 2014-06-06 16:34:32]

Change committed as 175674