Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Side by Side Diff: chrome/installer/test/alternate_version_generator.cc

Issue 318753007: Remove stale references to PlatformFile flags, errors or functions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // The file contains the implementation of the mini_installer re-versioner. 5 // The file contains the implementation of the mini_installer re-versioner.
6 // The main function (GenerateNextVersion) does the following in a temp dir: 6 // The main function (GenerateNextVersion) does the following in a temp dir:
7 // - Extracts and unpacks setup.exe and the Chrome-bin folder from 7 // - Extracts and unpacks setup.exe and the Chrome-bin folder from
8 // mini_installer.exe. 8 // mini_installer.exe.
9 // - Inspects setup.exe to determine the current version. 9 // - Inspects setup.exe to determine the current version.
10 // - Runs through all .dll and .exe files: 10 // - Runs through all .dll and .exe files:
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
196 PLOG(DFATAL) << "MapViewOfFile failed"; 196 PLOG(DFATAL) << "MapViewOfFile failed";
197 } 197 }
198 } else { 198 } else {
199 PLOG(DFATAL) << "CreateFileMapping failed"; 199 PLOG(DFATAL) << "CreateFileMapping failed";
200 } 200 }
201 } else { 201 } else {
202 LOG(DFATAL) << "Files larger than " << std::numeric_limits<DWORD>::max() 202 LOG(DFATAL) << "Files larger than " << std::numeric_limits<DWORD>::max()
203 << " are not supported."; 203 << " are not supported.";
204 } 204 }
205 } else { 205 } else {
206 PLOG(DFATAL) << "GetPlatformFileInfo failed"; 206 PLOG(DFATAL) << "file.GetInfo failed";
207 } 207 }
208 file_ = file.Pass(); 208 file_ = file.Pass();
209 return result; 209 return result;
210 } 210 }
211 211
212 // Calls CreateProcess with good default parameters and waits for the process 212 // Calls CreateProcess with good default parameters and waits for the process
213 // to terminate returning the process exit code. 213 // to terminate returning the process exit code.
214 bool RunProcessAndWait(const wchar_t* exe_path, const std::wstring& cmdline, 214 bool RunProcessAndWait(const wchar_t* exe_path, const std::wstring& cmdline,
215 int* exit_code) { 215 int* exit_code) {
216 bool result = true; 216 bool result = true;
(...skipping 474 matching lines...) Expand 10 before | Expand all | Expand 10 after
691 return false; 691 return false;
692 } 692 }
693 ctx.current_version_str = ctx.current_version.ToString(); 693 ctx.current_version_str = ctx.current_version.ToString();
694 ctx.new_version = ChromeVersion::FromString(version.GetString()); 694 ctx.new_version = ChromeVersion::FromString(version.GetString());
695 ctx.new_version_str = ctx.new_version.ToString(); 695 ctx.new_version_str = ctx.new_version.ToString();
696 696
697 return UpdateVersionIfMatch(target_file, &ctx); 697 return UpdateVersionIfMatch(target_file, &ctx);
698 } 698 }
699 699
700 } // namespace upgrade_test 700 } // namespace upgrade_test
OLDNEW
« no previous file with comments | « chrome/browser/media_galleries/win/mtp_device_operations_util.h ('k') | content/browser/child_process_security_policy_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698