Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: trunk/src/pdf/instance.cc

Issue 318743003: Revert 273547 "Reset scoped_ptr to make plugin crash before ente..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/pdf/instance.cc
===================================================================
--- trunk/src/pdf/instance.cc (revision 274853)
+++ trunk/src/pdf/instance.cc (working copy)
@@ -308,10 +308,6 @@
Instance::~Instance() {
RemovePerInstanceObject(kPPPPdfInterface, this);
- // TODO(vitalybuka): remove after crbug.com/372095 fixed.
- // Reset to NULL to make it crash in HandleDocumentLoad if called for
- // deleted instance. scoped_ptr::~scoped_ptr does not reset pointer to NULL.
- engine_.reset();
}
bool Instance::Init(uint32_t argc, const char* argn[], const char* argv[]) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698