Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 318733003: Use the media galleries controller interface for the scan result dialog. (Closed)

Created:
6 years, 6 months ago by vandebo (ex-Chrome)
Modified:
6 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, extensions-reviews_chromium.org, vandebo (ex-Chrome), Lei Zhang, tfarina, tommycli, Greg Billock, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Use the media galleries controller interface for the scan result dialog. Removes the second dialog implementation, which was a slightly modified version of the first one. BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=275554

Patch Set 1 #

Patch Set 2 : checkpoint #

Patch Set 3 : Rebase #

Total comments: 6

Patch Set 4 : Rebase and comments #

Patch Set 5 : One more const #

Unified diffs Side-by-side diffs Delta from patch set Stats (+284 lines, -2073 lines) Patch
M chrome/browser/extensions/api/media_galleries/media_galleries_api.h View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_api.cc View 1 2 3 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/api/media_galleries/media_galleries_apitest.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_dialog_controller.h View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
A chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h View 1 2 3 1 chunk +35 lines, -0 lines 0 comments Download
A chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.cc View 1 2 3 1 chunk +27 lines, -0 lines 0 comments Download
M chrome/browser/media_galleries/media_galleries_permission_controller_unittest.cc View 2 chunks +1 line, -32 lines 0 comments Download
A + chrome/browser/media_galleries/media_galleries_scan_result_controller.h View 1 2 5 chunks +34 lines, -70 lines 0 comments Download
A + chrome/browser/media_galleries/media_galleries_scan_result_controller.cc View 1 2 3 14 chunks +79 lines, -58 lines 0 comments Download
A + chrome/browser/media_galleries/media_galleries_scan_result_controller_unittest.cc View 1 2 3 4 18 chunks +67 lines, -104 lines 0 comments Download
D chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.h View 1 chunk +0 lines, -200 lines 0 comments Download
D chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller.cc View 1 2 3 1 chunk +0 lines, -364 lines 0 comments Download
D chrome/browser/media_galleries/media_galleries_scan_result_dialog_controller_unittest.cc View 1 chunk +0 lines, -461 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.h View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/extensions/media_galleries_dialog_cocoa.mm View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
D chrome/browser/ui/cocoa/extensions/media_galleries_scan_result_dialog_cocoa.h View 1 1 chunk +0 lines, -83 lines 0 comments Download
D chrome/browser/ui/cocoa/extensions/media_galleries_scan_result_dialog_cocoa.mm View 1 1 chunk +0 lines, -211 lines 0 comments Download
D chrome/browser/ui/cocoa/extensions/media_galleries_scan_result_dialog_cocoa_unittest.mm View 1 1 chunk +0 lines, -91 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.h View 1 2 3 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/browser/ui/views/extensions/media_galleries_dialog_views.cc View 1 2 3 2 chunks +12 lines, -0 lines 0 comments Download
D chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.h View 1 2 3 1 chunk +0 lines, -98 lines 0 comments Download
D chrome/browser/ui/views/extensions/media_galleries_scan_result_dialog_views.cc View 1 2 3 1 chunk +0 lines, -283 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 3 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
vandebo (ex-Chrome)
6 years, 6 months ago (2014-06-05 23:13:36 UTC) #1
Lei Zhang
lgtm https://codereview.chromium.org/318733003/diff/40001/chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h File chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h (right): https://codereview.chromium.org/318733003/diff/40001/chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h#newcode22 chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h:22: int update_count(); nit: const method https://codereview.chromium.org/318733003/diff/40001/chrome/browser/media_galleries/media_galleries_scan_result_controller.cc File chrome/browser/media_galleries/media_galleries_scan_result_controller.cc ...
6 years, 6 months ago (2014-06-06 07:03:10 UTC) #2
vandebo (ex-Chrome)
https://codereview.chromium.org/318733003/diff/40001/chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h File chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h (right): https://codereview.chromium.org/318733003/diff/40001/chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h#newcode22 chrome/browser/media_galleries/media_galleries_dialog_controller_test_util.h:22: int update_count(); On 2014/06/06 07:03:10, Lei Zhang wrote: > ...
6 years, 6 months ago (2014-06-06 17:43:31 UTC) #3
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-06 18:52:57 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/318733003/60001
6 years, 6 months ago (2014-06-06 18:54:28 UTC) #5
vandebo (ex-Chrome)
The CQ bit was checked by vandebo@chromium.org
6 years, 6 months ago (2014-06-06 19:15:05 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vandebo@chromium.org/318733003/80001
6 years, 6 months ago (2014-06-06 19:17:06 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-06 23:38:28 UTC) #8
Message was sent while issue was closed. 
Change committed as 275554

Powered by Google App Engine
This is Rietveld 408576698