Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 318723005: Modify getType to ensure that it does not result in initialization of (Closed)

Created:
6 years, 6 months ago by siva
Modified:
6 years, 6 months ago
Reviewers:
vsm, rmacnak
CC:
reviews_dartlang.org, ricow1
Visibility:
Public.

Description

Modify getType to ensure that it does not result in initialization of entries for all libraries on the first access to getType. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=37231

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -20 lines) Patch
M sdk/lib/_blink/dartium/_blink_dartium.dart View 1 3 chunks +83 lines, -12 lines 0 comments Download
M tools/dom/templates/html/dartium/_blink_dartium.darttemplate View 1 1 chunk +78 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
siva
6 years, 6 months ago (2014-06-06 23:11:41 UTC) #1
rmacnak
https://codereview.chromium.org/318723005/diff/1/tools/dom/templates/html/dartium/_blink_dartium.darttemplate File tools/dom/templates/html/dartium/_blink_dartium.darttemplate (right): https://codereview.chromium.org/318723005/diff/1/tools/dom/templates/html/dartium/_blink_dartium.darttemplate#newcode91 tools/dom/templates/html/dartium/_blink_dartium.darttemplate:91: return htmlBlinkMap[key](); Why are we calling the values in ...
6 years, 6 months ago (2014-06-09 17:07:18 UTC) #2
siva
https://codereview.chromium.org/318723005/diff/1/tools/dom/templates/html/dartium/_blink_dartium.darttemplate File tools/dom/templates/html/dartium/_blink_dartium.darttemplate (right): https://codereview.chromium.org/318723005/diff/1/tools/dom/templates/html/dartium/_blink_dartium.darttemplate#newcode91 tools/dom/templates/html/dartium/_blink_dartium.darttemplate:91: return htmlBlinkMap[key](); There is a CL by Vijay where ...
6 years, 6 months ago (2014-06-09 17:10:02 UTC) #3
vsm
lgtm. does this make much difference? the first one - html - is so big ...
6 years, 6 months ago (2014-06-11 15:04:52 UTC) #4
siva
6 years, 6 months ago (2014-06-11 15:56:24 UTC) #5
siva
6 years, 6 months ago (2014-06-11 15:56:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r37231 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698