Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 318723004: Test and css changes for dom_distiller inclusion of video. (Closed)

Created:
6 years, 6 months ago by Yaron
Modified:
6 years, 6 months ago
Reviewers:
cjhopman, blundell
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Test and css changes for dom_distiller inclusion of video. Adds tests for code in https://codereview.chromium.org/322553005/ Also, update stylesheet to restrict max video size. BUG=376107 TBR=blundell Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=276842

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -8 lines) Patch
M components/dom_distiller/content/distiller_page_web_contents_browsertest.cc View 1 2 chunks +27 lines, -0 lines 0 comments Download
M components/dom_distiller/core/css/distilledpage.css View 1 chunk +2 lines, -2 lines 0 comments Download
A + components/test/data/dom_distiller/video_article.html View 1 1 chunk +6 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Yaron
6 years, 6 months ago (2014-06-06 23:00:31 UTC) #1
cjhopman
https://codereview.chromium.org/318723004/diff/1/components/test/data/dom_distiller/simple_article.html File components/test/data/dom_distiller/simple_article.html (right): https://codereview.chromium.org/318723004/diff/1/components/test/data/dom_distiller/simple_article.html#newcode14 components/test/data/dom_distiller/simple_article.html:14: <video width="500" height="400" controls> I'd rather create a copy ...
6 years, 6 months ago (2014-06-06 23:11:06 UTC) #2
Yaron
https://codereview.chromium.org/318723004/diff/1/components/test/data/dom_distiller/simple_article.html File components/test/data/dom_distiller/simple_article.html (right): https://codereview.chromium.org/318723004/diff/1/components/test/data/dom_distiller/simple_article.html#newcode14 components/test/data/dom_distiller/simple_article.html:14: <video width="500" height="400" controls> On 2014/06/06 23:11:05, cjhopman wrote: ...
6 years, 6 months ago (2014-06-12 00:46:22 UTC) #3
cjhopman
lgtm
6 years, 6 months ago (2014-06-12 17:43:11 UTC) #4
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 6 months ago (2014-06-12 17:45:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/318723004/20001
6 years, 6 months ago (2014-06-12 17:47:51 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 6 months ago (2014-06-12 22:07:10 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-12 22:13:14 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/73416)
6 years, 6 months ago (2014-06-12 22:13:16 UTC) #9
Yaron
tbr'ing blundell for test data file
6 years, 6 months ago (2014-06-12 22:53:33 UTC) #10
Yaron
The CQ bit was checked by yfriedman@chromium.org
6 years, 6 months ago (2014-06-12 22:53:37 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yfriedman@chromium.org/318723004/20001
6 years, 6 months ago (2014-06-12 22:58:17 UTC) #12
commit-bot: I haz the power
Change committed as 276842
6 years, 6 months ago (2014-06-12 23:05:41 UTC) #13
blundell
6 years, 6 months ago (2014-06-13 07:31:37 UTC) #14
Message was sent while issue was closed.
rubberstamp lgtm

Powered by Google App Engine
This is Rietveld 408576698