Issue 318663002: Allow hitting the SVG root when its display-type is 'block'

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 318663002: Allow hitting the SVG root when its display-type is 'block' (Closed)

Created:
6 years, 6 months ago by fs

Modified:
6 years, 6 months ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-rendering, zoltan1, eae+blinkwatch, leviw+renderwatch, kouhei+svg_chromium.org, fs, ed+blinkwatch_opera.com, krit, f(malita), gyuyoung.kim_webkit.org, jchaffraix+rendering, rwlbuis, Stephen Chennney, rune+blink

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Allow hitting the SVG root when its display-type is 'block' The 'HitTestChildBlockBackground' hit test action needs to be considered as well when detecting hits on the SVG root container itself. BUG=379299 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=175528

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -5 lines)			Patch
A	LayoutTests/svg/hittest/svg-root-display-block.html	View	1 chunk	+23 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/hittest/svg-root-display-block-expected.txt	View	1 chunk	+3 lines, -0 lines	0 comments	Download
M	Source/core/rendering/svg/RenderSVGRoot.cpp	View	1 chunk	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/318663002/1

6 years, 6 months ago (2014-06-05 04:53:36 UTC) #4

Message was sent while issue was closed.

Change committed as 175528

Expand Messages | Collapse Messages